Re: Epiphany Bookmarks Patch h6

[Britt Selvitelle <britt muchobs com>]

Peter,

I've been playing with Epiphany using the patch a bit. So far everything
looks great! I think removing the bookmark toolbar in favor of any
number of generic toolbars works fine, and simplifies things a bit.
Although I must admit it took me a second to realize I *had* to drag and
drop bookmarks to get them there.

Maybe an option ala 'Add to Bookmark Bar' ... except worded 'Add to
Toolbar' which would then add the bookmark to the lowest right most spot
on a toolbar (which could then be moved). Just a thought.

Regarding compiling ... I couldn't get it to build myself. I'll attach
the error.

The deb package worked, but I had to force it to ignore dependencies,
since it looks for libxml2 >= 2.6.11. (I've got 2.6.10-3) I'm not
familiar with building debs, but I did some searching through the
package and couldn't find the reference to 2.6.11.

Britt

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../src -I../../embed -I../../lib/widgets -I../../lib/egg -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pango-1.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -DSHARE_DIR=\"/usr/local/share/epiphany\" -DDATADIR=\"/usr/local/share\" -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -g -O2 -MT ephy-bookmarksbar.lo -MD -MP -MF .deps/ephy-bookmarksbar.Tpo -c ephy-bookmarksbar.c  -fPIC -DPIC -o .libs/ephy-bookmarksbar.o
ephy-bookmarksbar.c: In function `ephy_bookmarksbar_action_request':
ephy-bookmarksbar.c:235: warning: passing arg 1 of `ephy_topic_action_new' from incompatible pointer type
ephy-bookmarksbar.c:235: warning: passing arg 2 of `ephy_topic_action_new' makes pointer from integer without a cast
ephy-bookmarksbar.c:235: error: too few arguments to function `ephy_topic_action_new'
ephy-bookmarksbar.c:242: warning: passing arg 1 of `ephy_bookmark_action_new' from incompatible pointer type
ephy-bookmarksbar.c:242: warning: passing arg 2 of `ephy_bookmark_action_new' makes pointer from integer without a cast
ephy-bookmarksbar.c:242: error: too few arguments to function `ephy_bookmark_action_new'
ephy-bookmarksbar.c: In function `ephy_bookmarksbar_set_property':
ephy-bookmarksbar.c:359: warning: implicit declaration of function `ephy_bookmarks_get_toolbars_model'
ephy-bookmarksbar.c:359: warning: assignment makes pointer from integer without a cast
make[4]: *** [ephy-bookmarksbar.lo] Error 1
make[4]: Leaving directory `/home/mbselv0/Downloads/epiphany-1.4.0/src/bookmarks'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/mbselv0/Downloads/epiphany-1.4.0/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/mbselv0/Downloads/epiphany-1.4.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/mbselv0/Downloads/epiphany-1.4.0'
make: *** [all] Error 2