Re: [evolution-patches] patch for week_view keyboard navigation.

[Harry Lu <harry lu sun com>]

JP,
    The logic there in e_week_view_focus is that when user TAB through weekview, it will focus in the events and jump buttons day by day, then to the weekview's underlying time table.
    In e_week_view, it crashes because week_view->events is correct but week_view->spans is NULL. For e_day_view, there is no such problem because in e_day_view_start_editing_event(), there is a check like following:

/* If the event is not shown, don't try to edit it. */
    if (!event->canvas_item)
        return;

    Thanks!
       Harry


JP Rosevear wrote:

On Wed, 2003-12-17 at 05:45, Harry Lu wrote:
  

Hi, JP,
    Bolian left SUN last week for his further education in USA. Wu
Yang also finished his internship in SUN.
    I will take care of what they left. Sorry I am not very familiar
with those code, either.
    Attached is the patch for the fix. Please review it.
       Harry
    

Looks good, I've committed it.  Could you review that code to ensure it
is correct?  I'm also wondering if e_day_view_focus needs a similar fix.

-JP