2004-10-04, 10:45 -0400, Rodney Dawes wrote: > No, the problem is that the version files are all that is getting > disted. These are generated from unversioned copies of the XML which > are missing from the tarball. The versioned copies should get removed > by make clean. It is only an issue in the tarball where they can't be > regenerated because the sources are missing. Got it. I got confused by the unversioned/versioned files.. But if they are distributed, they are should be in MAINTAINERCLEANFILES, not CLEANFILES. So they can be regenerated if needed but cleaned only by make maintainer-clean. It is not expected "make clean" or "make distclean" remove any distributed files (like po/*.gmo files) in autotool'ed packages. Alternatively, how about not distributing the versioned files at all? The rule is just "cp -f $< $@" so I don't think of any reason to distribute them. > On Sat, 2004-10-02 at 23:07 +0900, Changwoo Ryu wrote: > > 2004-09-29, 17:23 -0400, Rodney Dawes wrote: > > > This patch fixes a small disting issue in help/C/Makefile.am. The > > > original omf and xml files weren't getting properly disted, as they > > > were missing from EXTRA_DIST, and occasionally someone would have a > > > build failure in the help/C/ directory. This has not come up in our > > > package building though, so I didn't notice it. > > > > The files are already in EXTRA_DIST, by including help/xmldocs.make . > > > > The problem is they are in CLEANFILES. So if someone builds evolution > > in srcdir and does "make clean", it removes the omf and xml files. > > > > I already filed this as #67018. Patch attached. -- Changwoo Ryu <cwryu debian org>
Attachment:
signature.asc
Description: This is a digitally signed message part