Re: XMP import patch - Best version yet :)

[Bengt Thuree <bengt thuree com>]

Hi Guys

I added a new version of my patch :)

Check if extension .jpg (hmm... perhaps not so good! It;s a bit late
here)
   Check if jpg file has embedded xmp data
      Yes --> Continue with ImageFile
      No  --> Continue with Sidecar

/Bengt

On Thu, 2006-07-27 at 17:36 +0200, Stephane Delcroix wrote:
> Warren,
> 
> the main issue is what to do when the image have data in both XMP and
> image...
> one can think that because the user made a sidecar, that's were the
> information is, but here's my use case:
> 
> *joe has a picture /2005/event/img.jpg and want it to f-spot
> *joe write a sidecar, according to e.g. the path of the file. the
> important informations are in the sidecar
> *joe import his image to f-spot but choose to NOT copy it in ~/Photos
> *joe add some tags to the photo, tags are written to the image
> *joe remove his image from f-spot
> *joe want it back, then import it again... the important parts are now
> IN THE IMAGEFILE
> 
> so, we can't say a priori where looking for info.
> 
> my feeling is to import info from both places. it will work ok for
> keyword that will be converted into Tags, but what to do with unique
> informations, like picture title, or rating. what do we need to take in
> account ?
> 
> another solution should be to add a checkbox to the import dialog, but
> it's not the policy of F-Spot, having a lot of options in UI
> 
> definitly, we can surmount it !
> 
> and thx for the attached picture
> 
> 
> On Thu, 2006-07-27 at 11:13 -0400, Warren Baird wrote:
> > Stephane Delcroix wrote:
> > > My thoughts about this:
> > > 
> > > when I made the 'push for 342137', the expected behavior for this patch
> > > was to handle tags written by F-Spot. it's the most urgent feature to
> > > enable partial backups.
> > 
> > I definitely agree that's an important bit of functionality...   I'd 
> > also like to see a tag tree export mechanism...   It'd take me quite a 
> > while to rebuild my tree of tags...
> > 
> > > in the other hand, having an easy way to migrate from another
> > > application, or importing lot of pictures with additional information
> > > will bring new user and more love to F-Spot. and we need that also (I
> > > receive enough love at home for now, but ... )
> > 
> > Making it easier for users with a lot of photos with metadata to move to 
> > f-spot is important.   That's what motivated me to write my original 
> > version of the patch in the first place - I had ~5000 photos in iPhoto, 
> > all with metadata that I wanted to preserve.
> > 
> > I'm pretty sure this is surmountable -- I haven't looked into the image 
> > file thing yet, but I can see a few possible solutions:
> > 
> >    - fix the ImageFile class to do the 'right thing'
> >    - change the tag importer code to actually check for the presence of 
> > xmp records - I suspect we're getting an empty xmp structure back
> >    - modify the tag importer code to handle both sidecars and embedded 
> > xmp data appropriately...
> > 
> > 
> > > Warren, can you please send a picture with an attached sidecar ?
> > 
> > I've attached a tarball containing an image (without any xmp data) and a 
> > sidecar xmp file.   When I comment out the block I mentioned in bengt's 
> > patch, the image get's imported with several tags associated with it.
> > 
> > I scaled the image down a lot so the attachment doesn't take up too much 
> > space.
> > 
> > Warren