Re: BUILD: gdm spec file changes




Hello Omega,


On Tue, 20 Apr 1999 16:34:24 -0700 (PDT)
Erik Walthinsen <omega@cse.ogi.edu> wrote:

> I'm ready to commit changes to make the gdm spec file a spec.in file, to
> make it easier to build/release new versions of gdm (the spec file
> hardcodes the version number, spec.in allows autoconf to munge it).
> 
> Changes are below, with new spec.in file.  I'll commit them when I get the
> OK.
Can you make it a general rule (for the packages that use those
variables) that sysconfdir and localstatedir get AC_SUBST'ed in
foo.spec.in. I think those are two parameters users would want to
specify besides the $prefix.

Also, it might be a good thing to AC_SUBST %prefix as well.

Although I do not know how, maybe you can even pull off a trick to
make the package relocatable.  I think many users who do not have
root access, or users of non-RedHat distribution will appreciate it.

Here is a sample of what I am talking about.

[Sample spec.in for package foo]
%define prefix @prefix@

[snip]

%build
./configure --prefix=%prefix \
    --sysconfidir=@sysconfdir@ \
    --localstatedir=@localstatedir@

[snip]

%install
make -prefix=$RPM_BUILD_ROOT%prefix \
    --sysconfidir=$RPM_BUILD_ROOT@sysconfdir@ \
    --localstatedir=$RPM_BUILD_ROOT@localstatedir@

[snip]

%files
@localstatedir@/foo/*
@sysconfdir@/foorc
%prefix/bin/*


By the way, I am not your package maintainer.  I am supposed to
analyze build environment for GNOME.  When you have time, please read
the thread 'gnome build tool' in the archive and let me know what you
think.  Also, please take a look at the gbuild package in the CVS.
The author of gbuild is probably going to join the team as well.

Zen

----------/* E-Mail : <atmczen@ibm.net > */----------



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]