RE: An annoyingly regular 1.0.50 pep talk

[Tom Tromey <tromey cygnus com>]

>>>>> "Chris" == Chris Jones <chris@black-sun.co.uk> writes:

Chris> I looked at adding an option like SmFixedCwd to go along with
Chris> SmCurrentDirectory, but that would make the setting per app (I
Chris> think).

Yes, it would.  You don't want that.

Note that fixing the cwd like this can potentially break clients.  For
instance, if a client really does rely on running in the directory
which it asks for, and it isn't, then you're hosed.

Chris> gnome_config_get_string_with_default("/session-options/Options/FixedCwd=",
Chris> &def);

Please use the appropriate define in manager.h instead of hard-coding
the entire path name.

Chris> +          if(dir) g_free(dir); /* Is this needed? */

Please use the prevalent indentation and formatting style.

Tom