[PATCH] transient color-picker in gnome-libs 1.2.8

The colorpicker dialog (and others, but I just fix this now) are not set
as  transient. It's  something that I think should be done.

I've attached a small patch that fixes it. In the
gnome_color_picker_clicked() which is called when one presses the color
button and where the dialog is opened I've added:

toplevel = gtk_widget_get_toplevel (GTK_WIDGET (cp));
gtk_window_set_transient_for (GTK_WINDOW (cp->cs_dialog),
                              GTK_WINDOW (toplevel));

One call to get the toplevel window where the colorpicker-button is and
one to set the dialog transient (relative this window).

I have not checked GnomeFontPicker but I guess that the same thing should
be done there.

--- gnome-libs-1.2.4/libgnomeui/gnome-color-picker.c	Tue Aug  1 23:27:28 2000
+++ gnome-libs-1.2.8/libgnomeui/gnome-color-picker.c	Thu May  4 12:15:28 2000
@@ -452,7 +452,6 @@
 	} else {
 		/* Create the dialog and connects its buttons */
-		GtkWidget *toplevel;
 		cp->cs_dialog = gtk_color_selection_dialog_new (cp->title);
 		gnome_window_icon_set_from_default (GTK_WINDOW (cp->cs_dialog));
@@ -474,9 +473,6 @@
 		/* FIXME: do something about the help button */
 		gtk_window_set_position (GTK_WINDOW (cp->cs_dialog), GTK_WIN_POS_MOUSE);
-		toplevel = gtk_widget_get_toplevel (GTK_WIDGET (cp));
-		gtk_window_set_transient_for (GTK_WINDOW (cp->cs_dialog), GTK_WINDOW (toplevel));
 		/* If there is a grabed window, set new dialog as modal */
 		if (gtk_grab_get_current())

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]