patch for gnome-libs/libgnome (include of gnome-defs.h in files using BEGIN_GNOME_DECLS)

[Mikael Hallendal <micke hallendal net>]

Hi!

When trying to include libgnome/gnome-util.h I came across an anoying bug (I think). I had to include
gnome-defs.h just to be able to compile. Should this file be included in all files dependent on it?

If this is the case here is a patch I'd like to see included.

This is in cvs-version of gnome-libs revision: gnome-libs-1-0

Regards,
Mikael Hallendal

--
Mikael Hallendal                micke codefactory se
CodeFactory AB                  http://www.codefactory.se/
Office: +46 (0)8 587 583 05     Cell: +46 (0)709 718 918

Index: gnome-config.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-config.h,v
retrieving revision 1.25
diff -u -r1.25 gnome-config.h
--- gnome-config.h	1999/06/28 12:02:08	1.25
+++ gnome-config.h	2001/02/26 22:32:38
@@ -3,6 +3,8 @@
 
 #include <glib.h>
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /* Prototypes for the profile management functions */
Index: gnome-dentry.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-dentry.h,v
retrieving revision 1.16
diff -u -r1.16 gnome-dentry.h
--- gnome-dentry.h	1999/08/27 22:41:26	1.16
+++ gnome-dentry.h	2001/02/26 22:32:39
@@ -1,6 +1,8 @@
 #ifndef __GNOME_DENTRY_H__
 #define __GNOME_DENTRY_H__
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 typedef struct {
Index: gnome-exec.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-exec.h,v
retrieving revision 1.7
diff -u -r1.7 gnome-exec.h
--- gnome-exec.h	1999/01/12 05:36:49	1.7
+++ gnome-exec.h	2001/02/26 22:32:39
@@ -17,10 +17,11 @@
    write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-#include <glib.h>
-
 #ifndef GNOME_EXEC_H
 #define GNOME_EXEC_H
+
+#include <glib.h>
+#include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS
 
Index: gnome-fileconvert.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-fileconvert.h,v
retrieving revision 1.4
diff -u -r1.4 gnome-fileconvert.h
--- gnome-fileconvert.h	1999/07/29 01:26:30	1.4
+++ gnome-fileconvert.h	2001/02/26 22:32:39
@@ -3,6 +3,8 @@
 
 /* WARNING ____ IMMATURE API ____ liable to change */
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /* Returns -1 if no conversion is possible */
Index: gnome-help.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-help.h,v
retrieving revision 1.7
diff -u -r1.7 gnome-help.h
--- gnome-help.h	1999/01/20 23:29:18	1.7
+++ gnome-help.h	2001/02/26 22:32:39
@@ -2,7 +2,7 @@
 #define __GNOME_HELP_H__ 1
 
 #include <glib.h>
-#include "gnome-defs.h"
+#include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS
 
Index: gnome-history.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-history.h,v
retrieving revision 1.4
diff -u -r1.4 gnome-history.h
--- gnome-history.h	1998/12/01 23:07:36	1.4
+++ gnome-history.h	2001/02/26 22:32:39
@@ -21,6 +21,8 @@
 
 /* WARNING ____ IMMATURE API ____ liable to change */
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /* One of these structures is created for each file in the history.  */
Index: gnome-i18n.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-i18n.h,v
retrieving revision 1.9
diff -u -r1.9 gnome-i18n.h
--- gnome-i18n.h	1999/09/19 23:37:48	1.9
+++ gnome-i18n.h	2001/02/26 22:32:39
@@ -10,6 +10,8 @@
 #warning "You should use either gnome-i18n.h OR gnome-i18nP.h"
 #endif
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 #ifdef ENABLE_NLS
Index: gnome-i18nP.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-i18nP.h,v
retrieving revision 1.4
diff -u -r1.4 gnome-i18nP.h
--- gnome-i18nP.h	1998/08/17 05:11:10	1.4
+++ gnome-i18nP.h	2001/02/26 22:32:39
@@ -11,6 +11,8 @@
 #warning "You should use either gnome-i18n.h OR gnome-i18nP.h"
 #endif
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 #ifdef ENABLE_NLS
Index: gnome-magic.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-magic.h,v
retrieving revision 1.2
diff -u -r1.2 gnome-magic.h
--- gnome-magic.h	1999/01/05 19:48:41	1.2
+++ gnome-magic.h	2001/02/26 22:32:39
@@ -1,6 +1,8 @@
 #ifndef __GNOME_MAGIC_H__
 #define __GNOME_MAGIC_H__
 
+#include <libgnome/gnome-defs.h>
+
 /*
  * Do not include this file in libgnome.h as it is of little use for
  * other applications.
Index: gnome-metadata.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-metadata.h,v
retrieving revision 1.4
diff -u -r1.4 gnome-metadata.h
--- gnome-metadata.h	1999/01/11 01:23:29	1.4
+++ gnome-metadata.h	2001/02/26 22:32:40
@@ -20,6 +20,8 @@
 #ifndef GNOME_METADATA_H
 #define GNOME_METADATA_H
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 
Index: gnome-mime.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-mime.h,v
retrieving revision 1.8
diff -u -r1.8 gnome-mime.h
--- gnome-mime.h	1999/01/27 02:16:08	1.8
+++ gnome-mime.h	2001/02/26 22:32:40
@@ -1,6 +1,8 @@
 #ifndef __GNOME_MIME_H__
 #define __GNOME_MIME_H__
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /* do not free() any of the returned values */
Index: gnome-popt.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/Attic/gnome-popt.h,v
retrieving revision 1.3
diff -u -r1.3 gnome-popt.h
--- gnome-popt.h	1999/01/13 21:59:54	1.3
+++ gnome-popt.h	2001/02/26 22:32:40
@@ -2,7 +2,7 @@
 #define __GNOME_POPT_H__ 1
 
 
-#include "gnome-defs.h"
+#include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS
 
Index: gnome-regex.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-regex.h,v
retrieving revision 1.2.10.2
diff -u -r1.2.10.2 gnome-regex.h
--- gnome-regex.h	2000/10/18 13:33:46	1.2.10.2
+++ gnome-regex.h	2001/02/26 22:32:40
@@ -20,6 +20,8 @@
 #ifndef GNOME_REGEX_H
 #define GNOME_REGEX_H
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 #include <sys/types.h>
Index: gnome-remote.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-remote.h,v
retrieving revision 1.3
diff -u -r1.3 gnome-remote.h
--- gnome-remote.h	1998/12/09 01:45:55	1.3
+++ gnome-remote.h	2001/02/26 22:32:40
@@ -20,6 +20,8 @@
 #ifndef GNOME_REMOTE_H
 #define GNOME_REMOTE_H
 
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /* Return a command which should be used to run a program on HOST.
Index: gnome-score.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-score.h,v
retrieving revision 1.7
diff -u -r1.7 gnome-score.h
--- gnome-score.h	1998/02/26 23:25:23	1.7
+++ gnome-score.h	2001/02/26 22:32:40
@@ -4,6 +4,7 @@
 #include <time.h>
 #include <glib.h>
 #include <glib.h>
+#include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS
 /*
Index: gnome-sound.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-sound.h,v
retrieving revision 1.3
diff -u -r1.3 gnome-sound.h
--- gnome-sound.h	1998/11/20 04:19:46	1.3
+++ gnome-sound.h	2001/02/26 22:32:40
@@ -1,8 +1,9 @@
 #ifndef __GNOME_SOUND_H__
 #define __GNOME_SOUND_H__ 1
 
-#include "gnome-defs.h"
 #include <glib.h>
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 /*
Index: gnome-triggers.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-triggers.h,v
retrieving revision 1.10
diff -u -r1.10 gnome-triggers.h
--- gnome-triggers.h	1999/09/08 09:19:26	1.10
+++ gnome-triggers.h	2001/02/26 22:32:40
@@ -1,8 +1,9 @@
 #ifndef __GNOME_TRIGGERS_H__
 #define __GNOME_TRIGGERS_H__
 
-#include "gnome-defs.h"
 #include <glib.h>
+#include <libgnome/gnome-defs.h>
+
 BEGIN_GNOME_DECLS
 
 typedef enum {
Index: gnome-url.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-url.h,v
retrieving revision 1.2
diff -u -r1.2 gnome-url.h
--- gnome-url.h	1998/12/12 16:41:32	1.2
+++ gnome-url.h	2001/02/26 22:32:41
@@ -18,6 +18,7 @@
 
 #ifndef GNOME_URL_H
 #define GNOME_URL_H
+
 #include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS
Index: gnome-util.h
===================================================================
RCS file: /cvs/gnome/gnome-libs/libgnome/gnome-util.h,v
retrieving revision 1.17
diff -u -r1.17 gnome-util.h
--- gnome-util.h	1999/01/25 21:53:50	1.17
+++ gnome-util.h	2001/02/26 22:32:41
@@ -3,6 +3,7 @@
 
 #include <stdlib.h>
 #include <glib.h>
+#include <libgnome/gnome-defs.h>
 
 BEGIN_GNOME_DECLS