Re: patch for gnome-libs/libgnome (include of gnome-defs.h in files using BEGIN_GNOME_DECLS)

On 27 Feb 2001 12:00:03 +0800, James Henstridge wrote:
> On 26 Feb 2001, Mikael Hallendal wrote:
> > Hi!
> > 
> > When trying to include libgnome/gnome-util.h I came across an anoying bug (I think). I had to include
> > gnome-defs.h just to be able to compile. Should this file be included in all files dependent on it?
> > 
> > If this is the case here is a patch I'd like to see included.
> > 
> > This is in cvs-version of gnome-libs revision: gnome-libs-1-0
> You should be including <gnome.h> rather than <libgnome/gnome-utils.h>
> Or if you just want to link with libgnome (and not libgnomeui), use
> <libgnome/libgnome.h>.

Why should this be necessary? If I only want the funcionality of one of
the files I can't see why including 100 
h-files (or 21 if only include libgnome.h).  As I see it a file should
include the files it needs. In this case 
libgnome/gnome-util.h needs libgnome/gnome-defs.

Mikael Hallendal


| email    : micke hallendal net
| sms      : micke mobil hallendal net
| homepage :
| PGP-key  :

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]