Re: Intolerable CVS behaviour

[Daniel Veillard <veillard redhat com>]

On Sat, Feb 24, 2001 at 03:05:44PM +0100, Tomasz Kloczko wrote:
> OK. You have right about my fault.

  Okay, so I assume you understand the problem, I suggest we reenable
your CVS account. But please learn from this episode.

> But look ones agan on my changes. Is it correct (in spe) or not. If I
> remove on this big change some files I want apologize.
> But if this changes is correct (at all) and if something require fix IMHO
> is better fix this instead reverte rhis.
> I'm not XLM specialist but I know very well autoconf/automake abilities
> and twings which I know.

  Okay on technical standpoint:
    - this change is right or at least in principle is
    - but I expected to do this when creating a new CVS module
      when starting the next version
    - I don't want to do it now because I don't want to loose history
      the only way to not loose CVS history properly and move file is
      by creating a new module.
    - the existing autoconf/automake stuff of gnome-xml is really complex
      because it creates tar.gz with the subdirectory even if it
      doesn't exists in CVS.
    - the fact that you didn't understand the context of this complexity
      is no excuse for deciding on your own to change it.

> Yes this is my mistake. I'm not read before HACKING documment.
> But ones more .. look on this change and evaluate them and simple say is
> it correct or not.

  It looks correct from a narrowed point of view, it would have lost
CVS history, and from what I have seen would have broken completely
the Windows build and Makefiles [1]. You had very little understanding of
the context. This is the main common mistake when someone tries to 
provide fixes for a project it doesn't knows well. The very first thing
is to ask beforehand if you have direct commit access.

Daniel

[1] and currently my user base for Windows has outgrown the Gnome one,
    I get more 'good' patches from the other side, probably because
    they were not stuck to libxml1. Not breaking the Windows build is
    really important to me right now.

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard redhat com  | libxml Gnome XML toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/