Re: Additional language entries in gdm



mn 2003-02-17 klockan 14.08 skrev Ross Golder:
> > Oh, thanks for the help!
> 
> You're welcome. I've corrected the cock-ups and attached a fresh patch.

Thanks. Below are my comments on the new patch.


> > I found some issues in the patch:
> > 
> > +Bengali                        bn_BD.UTF-8,bn_BD
> > +Bengali (Indian)                       bn_IN.UTF-8,bn_IN
> > 
> > Don't know if a space is allowed there before the paranthesis. 
> > Should perhaps be "India" rather than "Indian".
> 
> Nope, the other similar entries that use brackets do not have spaces in
> them. Well spotted. Space removed.

Did you change to "India" too?


> > +Gujrati                        gj_IN.UTF-8,gj_IN
> > 
> > Should be spelled "Gujarati"
> 
> Un-typoed.
> 
>
> > +Hindu                  hi_IN.UTF-8,hi_IN
> > 
> > Should be spelled "Hindi"
> 
> Untypoed.
> 
>
> > +Interlingua                    ia_IA.UTF-8,ia_IA
> > 
> > I don't believe "IA" is a valid country code. Interlingua is also an
> > international language that I don't think is, or should be, tied to a
> > particular locale.
> 
> OK, how should I proceed? In the revised patch, I've guessed it should
> just read 'ia.UTF-8,ia'.

That's probably the best option. Or using Pablo's suggestion of ia_XX.
Don't know which ones of them are most valid.


> > +Kannada                        ka_KA.UTF-8,ka_KA
> > 
> > "KA" is not a valid country code. Kannada is only widely spoken in
> > India, which would make the locale "ka_IN" (which is also what the bug
> > report says).
> 
> Sorry. Probably best not to invite me to a game of Trivial Pursuit!

As Pablo pointed out, it should be "kn_IN", and not "ka_IN" or anything
else, here. Sory for my goofup.


> > +Punjabi                        pa_IN.UTF-8,pa_IN
> > 
> > Should be spelled "Panjabi"
> 
> Thanks. I'm also not expecting an invitation to 'Who wants to be a
> millionaire?'!
> 
>
> > +       { N_("A-M|Gujrati"), "gj_IN", NULL, 0 },
> > +       /*Note translate the A-M to the A-M you used in the group label */
> > 
> > Should be spelled "Gujarati"
> > We don't have any Gujarati translations yet, so I don't should be added
> > as an option yet.
> 
> OK, commented out until we get one.
> 
>
> > +       { N_("A-M|Hindu"), "hi_IN", NULL, 0 },
> > 
> > Should be spelled "Hindi"
> 
> Yup.
> 
>
> > -       { N_("A-M|Irish"), "ga_IE", NULL, 0 },
> > 
> > Why was this removed? We have some Irish translations.
> 
> Doh, a stray cut. /me kicks himself for not checking the patch closely
> enough. Re-instated, using 'Gaeilge' as description (thanks Pablo).

Ok, excellent.


> > +       { N_("A-M|Indonesian"), "id_ID", "Bahasa Indonesia [id]", 0 },
> > 
> > The language code shouldn't be present in the native name (remove the "
> > [id]").
> 
> No problem.
> 
>
> > +       /*Note translate the A-M to the A-M you used in the group label */
> > +       { N_("A-M|Interlingua"), "ia_IA", NULL, 0 },
> > 
> > IA isn't a valid country code
> 
> As above, country code removed (now just "ia").
> 
>
> > +        /*Note translate the A-M to the A-M you used in the group label */
> > +        { N_("A-M|Malayalam"), "ml_IN", NULL, 0 },
> > 
> > We don't have any Malayalam translations yet, so I don't should be added
> > as an option yet.
> 
> Commented out.
> 
>
> > +        /*Note translate the A-M to the A-M you used in the group label */
> > +        { N_("A-M|Marathi"), "mr_IN", NULL, 0 },
> > 
> > We don't have any Marathi translations yet, so I don't should be added
> > as an option yet.
> 
> Commented out.
> 
>
> > +       { N_("N-Z|Oriya"), "or_IN", NULL, 0 },
> > 
> > We don't have any Oriya translations yet, so I don't should be added as
> > an option yet.
> 
> Same.
> 
>
> > +       { N_("N-Z|Punjabi"), "pa_IN", NULL, 0 },
> > 
> > Should be spelled "Panjabi"
> 
> Yup. :)
> 
>
> > +       /*Note translate the N-Z to the N-Z you used in the group label */
> > +       { N_("N-Z|Welsh"), "cy_GB", "Cymru", 0 },
> > 
> > I don't know any Welsh, but the http://www.gnome.org/i18n/ says the
> > native name is "Cymraeg". Don't know which one is correct.
> 
> That's a cool page. Corrected.
> 'Cymraig' used.

"Cymraeg" was the correct spelling, no?


> > Also, Yiddish wasn't added as an option?
> 
> It is now. I've added it as just 'yi'. Can anyone tell me if it has a
> country code part and or a localized name.

It's not tied very much to a particular locale, should probably use the
same solution as for Interlingua.
As for the native name, you can probably copy-paste it directly from
http://www.gnome.org/i18n/.

Below are specific comments in the patch:


> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gdm2/ChangeLog,v
> retrieving revision 1.647
> diff -u -u -r1.647 ChangeLog
> --- ChangeLog	16 Feb 2003 10:24:35 -0000	1.647
> +++ ChangeLog	17 Feb 2003 13:07:32 -0000
> @@ -1,3 +1,10 @@
> +2003-02-17  Ross Golder <rossg@golder.org>
> +
> +	* gui/gdmlanguage.c, config/locale.alias: Added language support
> +	  for these languages - Mongolian, Indonesian, Kannada, Hindi
> +	  Bengali, Belarusian, Bosnian, Welsh, Persian, Interlingua,
> +	  Albanian, Serbian, Yiddish.
> +
>  2003-02-16  Kjartan Maraas  <kmaraas@gnome.org>
>  
>  	* daemon/verify-crypt.c: Fix typo in comment.
> Index: config/locale.alias
> ===================================================================
> RCS file: /cvs/gnome/gdm2/config/locale.alias,v
> retrieving revision 1.30
> diff -u -u -r1.30 locale.alias
> --- config/locale.alias	13 Feb 2003 07:34:47 -0000	1.30
> +++ config/locale.alias	17 Feb 2003 13:07:33 -0000
> @@ -15,10 +15,15 @@
>  #		- George
>  
>  Azerbaijani		az_AZ.UTF-8,az_AZ
> +Albanian			sq_AL.UTF-8,sq_AL
>  Arabic(Egypt)		ar_EG.UTF-8,ar_EG
>  Arabic(Lebanon)		ar_LB.UTF-8,ar_LB
>  Amharic			am_ET.UTF-8,am_ET
>  Basque			eu_ES.UTF-8,eu_ES
> +Bosnian			bs_BA.UTF-8,bs_BA
> +Belarusian			be_BY.UTF-8,be_BY
> +Bengali			bn_BD.UTF-8,bn_BD
> +Bengali(Indian)			bn_IN.UTF-8,bn_IN
>  Bulgarian		bg_BG.UTF-8,bg_BG
>  Catalan			ca_ES.UTF-8,ca_ES
>  Chinese(simplified)	zh_CN.UTF-8,zh_CN
> @@ -37,24 +42,36 @@
>  Galician		gl_ES.UTF-8,gl_ES
>  German			de_DE.UTF-8,de_DE
>  Greek			el_GR.UTF-8,el_GR
> +Gujarati			gj_IN.UTF-8,gj_IN

Language code isn't "gj", it's "gu". Check with
http://lcweb.loc.gov/standards/iso639-2/englangn.html if you are unsure.


>  Hebrew			he_IL.UTF-8,he_IL
> +Hindi			hi_IN.UTF-8,hi_IN
>  Hungarian		hu_HU.UTF-8,hu_HU
>  Icelandic		is_IS.UTF-8,is_IS
> +Indonesian			id_ID.UTF-8,id_ID
> +Interlingua			ia.UTF-8,ia
>  Irish			ga_IE.UTF-8,ga_IE
>  Italian			it_IT.UTF-8,it_IT
>  Japanese		ja_JP.UTF-8,ja_JP
>  Korean			ko_KR.UTF-8,ko_KR
> +Kannada			ka_IN.UTF-8,ka_IN

Should be "kn_IN" as already noted.


>  Latvian			lv_LV.UTF-8,lv_LV
>  Lithuanian		lt_LT.UTF-8,lt_LT
>  Macedonian		mk_MK.UTF-8,mk_MK
>  Malay			ms_MY.UTF-8,ms_MY
> +Malayalam			ml_IN.UTF-8,ml_IN
> +Marathi			mr_IN.UTF-8,mr_IN
> +Mongolian			mn_MN.UTF_8,mn_MN
>  Norwegian(bokmal)	no_NO.UTF-8,no_NO
>  Norwegian(nynorsk)	nn_NO.UTF-8,nn_NO
> +Oriya			or_IN.UTF-8,or_IN
> +Persian			fa_IR.UTF-8,fa_IR
>  Polish			pl_PL.UTF-8,pl_PL
>  Portuguese		pt_PT.UTF-8,pt_PT
>  Portuguese(Brazilian)	pt_BR.UTF-8,pt_BR
> +Panjabi			pa_IN.UTF-8,pa_IN
>  Romanian		ro_RO.UTF-8,ro_RO
>  Russian			ru_RU.UTF-8,ru_RU
> +Serbian			sr_YU.UTF-8,sr_YU
>  Slovak			sk_SK.UTF-8,sk_SK
>  Slovenian		sl_SI.UTF-8,sl_SI
>  Spanish			es_ES.UTF-8,es_ES
> @@ -62,8 +79,11 @@
>  Swedish			sv_SE.UTF-8,sv_SE
>  Swedish(Finland)	sv_FI.UTF-8,sv_FI
>  Tamil			ta_IN.UTF-8,ta_IN
> +Telugu			te_IN.UTF-8,te_IN
>  Thai			th_TH.UTF-8,th_TH
>  Turkish			tr_TR.UTF-8,tr_TR
>  Ukrainian		uk_UA.UTF-8,uk_UA
>  Vietnamese		vi_VN.UTF-8,vi_VN
>  Walloon			wa_BE.UTF-8,wa_BE
> +Welsh			cy_GB.UTF-8,cy_GB
> +Yiddish			yi.UTF-8,yi
> Index: gui/gdmlanguages.c
> ===================================================================
> RCS file: /cvs/gnome/gdm2/gui/gdmlanguages.c,v
> retrieving revision 1.24
> diff -u -u -r1.24 gdmlanguages.c
> --- gui/gdmlanguages.c	13 Feb 2003 07:34:47 -0000	1.24
> +++ gui/gdmlanguages.c	17 Feb 2003 13:07:34 -0000
> @@ -52,6 +52,8 @@
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Azerbaijani"), "az_AZ", NULL, 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Albanian"), "sq_AL", "Shqip", 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Amharic"), "am_ET", NULL, 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Arabic (Egypt)"), "ar_EG", NULL, 0 },
> @@ -60,8 +62,16 @@
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Basque"), "eu_ES", "Euskara", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Belarusian"), "be_BY", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Bengali"), "bn_BD", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */

You have Bengali spelled in UTF-8 in
http://bugzilla.gnome.org/show_bug.cgi?id=105825. Could probably use
that.


> +	{ N_("A-M|Bengali (India)"), "bn_IN", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Bulgarian"), "bg_BG", "Български", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Bosnian"), "bs_BA", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Catalan"), "ca_ES", "Catal ", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Chinese (simplified)"), "zh_CN", "中文 (简体)", 0 },
> @@ -98,19 +108,30 @@
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Greek"), "el_GR", "ελληνικά", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Gujarati"), "gj_IN", NULL, 0 },

Should be "gu_IN", but we don't have any gu translations, so shouldn't
be listed.


> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Hebrew"), "he_IL", "עברית", 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Hebrew"), "iw_IL", "עברית", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Hindi"), "hi_IN", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */

You have Hindi spelled natively in
http://bugzilla.gnome.org/show_bug.cgi?id=105655.


>  	{ N_("A-M|Hungarian"), "hu_HU", "Magyar", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Icelandic"), "is_IS", NULL, 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> -	{ N_("A-M|Irish"), "ga_IE", NULL, 0 },
> +	{ N_("A-M|Indonesian"), "id_ID", "Bahasa Indonesia", 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Interlingua"), "ia", NULL, 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Irish"), "ga_IE", "Gaeilge", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Italian"), "it_IT", "Italiano", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Japanese"), "ja_JP", "日本語", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
> +	{ N_("A-M|Kannada"), "ka_IN", "ಕನ್ನಡ", 0 },
> +	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Korean"), "ko_KR", "한국어", 0 },
>  	/*Note translate the A-M to the A-M you used in the group label */
>  	{ N_("A-M|Latvian"), "lv_LV", "Latviešu", 0 },
> @@ -120,21 +141,35 @@
>          { N_("A-M|Macedonian"), "mk_MK", NULL, 0 },
>          /*Note translate the A-M to the A-M you used in the group label */
>          { N_("A-M|Malay"), "ms_MY", "Bahasa Melayu", 0 },
> +        /*Note translate the A-M to the A-M you used in the group label */
> +        /* { N_("A-M|Malayalam"), "ml_IN", NULL, 0 }, */

We don't have any ml translations yet, should probably not be listed.


> +        /*Note translate the A-M to the A-M you used in the group label */
> +        /* { N_("A-M|Marathi"), "mr_IN", NULL, 0 }, */

The same.


> +        /*Note translate the A-M to the A-M you used in the group label */
> +        { N_("A-M|Mongolian"), "mn_MN", "Монгол", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Norwegian (bokmal)"), "no_NO", "Norsk (bokmål)", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Norwegian (nynorsk)"), "nn_NO", "Norsk (nynorsk)", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
> +	/* { N_("N-Z|Oriya"), "or_IN", NULL, 0 }, */
> +	/*Note translate the N-Z to the N-Z you used in the group label */

The same.


> +	{ N_("N-Z|Persian"), "fa_IR", "فارسی", 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Polish"), "pl_PL", "Polski", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Portuguese"), "pt_PT", "Português", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Portuguese (Brazilian)"), "pt_BR", "Português do Brasil", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
> +	{ N_("N-Z|Panjabi"), "pa_IN", NULL, 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */

Dito.


>  	{ N_("N-Z|Romanian"), "ro_RO", "Română", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Russian"), "ru_RU", "русский", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
> +	{ N_("N-Z|Serbian"), "sr_YU", "", 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */

You can probably fetch the native spelling from
http://www.gnome.org/i18n/. Don't know if you shoose the latin or
cyrillic one.


>  	{ N_("N-Z|Slovak"), "sk_SK", "Slovenský", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Slovenian"), "sl_SI", "Slovenščina", 0 },
> @@ -149,6 +184,8 @@
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Tamil"), "ta_IN", NULL, 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
> +	{ N_("N-Z|Telugu"), "te_IN", NULL, 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */

We don't have any te translations yet, so should probably not be listed.


>  	{ N_("N-Z|Thai"), "th_TH", "ไทย", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Turkish"), "tr_TR", "Türkçe", 0 },
> @@ -158,6 +195,10 @@
>  	{ N_("N-Z|Vietnamese"), "vi_VN", "Việt Nam", 0 },
>  	/*Note translate the N-Z to the N-Z you used in the group label */
>  	{ N_("N-Z|Walloon"), "wa_BE", "Walon", 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */
> +	{ N_("N-Z|Welsh"), "cy_GB", "Cymraeg", 0 },
> +	/*Note translate the N-Z to the N-Z you used in the group label */
> +	{ N_("N-Z|Yiddish"), "yi", NULL, 0 },

Can probably copy+paste the native spelling from
http://www.gnome.org/i18n/.


Cheers,
Christian





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]