Re: Incorrect translation causes evolution segfault

[danilo gnome org (Danilo Åegan)]

Today at 7:10, Tino Meinen wrote:

> #: mail/em-composer-utils.c:1511
> msgid "On %a, %Y-%m-%d at %H:%M %%+05d, %%s wrote:"
> msgstr "Op %a %d-%m-%Y, om %H:%M %%+05d uur schreef %%s:"
>
> But this should be ok ?! gettext has no problem verifying it. And
> putting the %%s string *before* the translation of 'wrote' (schreef) is
> gramatically not correct in Dutch, so we'd rather keep it this way.
> If evolution crashes with this translation, evolution should be fixed
> methinks.

Yeah, this should be ok.  

"msgfmt -cv" cannot detect errors here, because we have a string first
passed to strftime, so "%%" is used instead of "%" to escape sequences
passed to printf-style functions, and msgfmt knows nothing about it.

That's the catch, and this is the reason we should ask of Evolution
hackers to add some checks for translations (just skip faulty ones
during build), so at least there're no crashes.

Cheers,
Danilo