Re: [gnome-network] [PATCH] integrating the GST network tool with gnome-nettool

[German Poo Caaman~o <gpoo ubiobio cl>]

El jue, 10-06-2004 a las 19:11, Carlos Garnacho escribió:
> Hi rodrigo!
> 
> El jue, 10-06-2004 a las 12:38, +0200, Rodrigo Moya escribió:
> > On Wed, 2004-06-09 at 23:26 +0200, Carlos Garnacho wrote:
> > > Hi all,
> > > 
> > > 	Ive just readapted the good ol' patch for integrating nettool with
> > > network-admin from g-s-t with the current CVS code, it adds a
> > > "configure" button that displays a dialog for configuring that interface
> > > if network-admin is available, if it doesn't exist it just hides the
> > > button. it's OK to commit? :)
> > 
> > > +       if (gtk_combo_box_get_active_iter (combo, &iter)) {
> > > +               gtk_tree_model_get (model, &iter, 2, &nic, -1);
> > > +
> > > +               command_line = g_string_new (info->network_tool_path);
> > > +               g_string_append (command_line, " --configure ");
> > > +               g_string_append (command_line, nic);
> > > +
> > > +               g_spawn_command_line_async (command_line->str, NULL);
> > > +
> > here, I would add error processing, so that we can display an error
> > dialog if something goes wrong.
> > 
> > Apart from that, it looks ok to me, so please commit.
> 
> It's commited, I've added error processing and removed an unused
> variable, I've attached the committed patch :)

Good!  Thanks!.

-- 
Germán Poó Caamaño
mailto:gpoo ubiobio cl
http://www.ubiobio.cl/~gpoo/