Redundant APIs in eel and gnome-vfs

[Kjartan Maraas <kmaraas broadpark no>]

Hi.

I went looking at stuff in eel/eel/gnome-vfs-extensions.c and compared
that to gnome-vfs to see if there's any redundant stuff in there that
could be removed from eel or improvements that could be lifted from eel
and put into gnome-vfs. Here's the result.

eel_read_entire_file() / gnome_vfs_read_entire_file()

- exactly the same in both places

static char *			vs.	char *
gnome_vfs_make_valid_utf8()		eel_make_valid_utf8()

- same except s/static//

static char * eel_format_uri_for_display_internal (const char *uri,
gboolean filenames_are_locale_encoded)

vs.

static char *
gnome_vfs_format_uri_for_display_internal (const char *uri, gboolean
filenames_are_locale_encoded)

- exactly the same

char *
eel_format_uri_for_display (const char *uri)

vs.

char *
gnome_vfs_format_uri_for_display (const char *uri)

- the same

is_valid_scheme_character() is in both places

has_valid_scheme() is also duplicated 

eel_escape_high_chars() and gnome_vfs_escape_high_chars() are the same

eel_make_uri_from_input_internal() vs.
gnome_vfs_make_uri_from_input_internal()

- the gnome-vfs version has code to handle file:// and http:// the eel
version only has the latter it seems

eel_make_uri_from_input() is the same as the gnome-vfs counterpart.

eel_make_uri_from_shell_arg() is duplicated as well

eel_make_uri_canonical_strip_fragment() also

uris_match() also

eel_uris_match() also

eel_str_has_prefix() also

eel_uri_is_local_scheme() also

eel_handle_trailing_slashes() also

eel_vfs_make_uri_canonical() is the same except for code to specifically
handle trash:// it seems. Although gnome_vfs_make_uri_canonical() is
calling gnome_vfs_make_uri_canonical_old() somewhere in there instead of
calling itself recursively. The eel version doesn't use the _old()
function.

eel_make_uri_from_shell_arg() is duplicate

eel_make_uri_full_from_relative() seems to have a better implementation
than it's gnome-vfs counterpart. Maybe those should be merged.

eel_uri_get_scheme() is not similar to the gnome-vfs counterpart. Use
gnome-vfs instead?

Hope this can be of some help to people interested in cleaning up old
cruft.

Cheers
Kjartan