API-Freeze break approval (gnome_vfs_next_address renaming)



Hi!

Some people on the gnome-vfs mailing list complained about the poor
naming of gnome_vfs_next_address(). I think they are right, but I was
too busy getting our new http module in that I forgot about that. So I
am now requesting approval for renaming gnome_vfs_next_address to
gnome_vfs_resolve_next_address. The patch for doing this is included. 
I don't think the API is yet used outside the gnome-vfs library (except
the language bindings) because I recently added it while integrating the
neon library, so it's brand new and that's why I think it should be
changed right now.

Thank you,
Christian
? rename.patch
? imported/Makefile
? imported/Makefile.in
? imported/neon/Makefile.in
? libgnomevfs/s-enum-types-c
? libgnomevfs/s-enum-types-h
? test/test-dns-sd
? test/test-mime-info-cache
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gnome-vfs/ChangeLog,v
retrieving revision 1.1888
diff -u -r1.1888 ChangeLog
--- ChangeLog	27 Jul 2004 15:33:25 -0000	1.1888
+++ ChangeLog	27 Jul 2004 19:25:16 -0000
@@ -1,3 +1,12 @@
+2004-07-27  Christian Kellner  <gicmo gnome-de org>
+
+	* libgnomevfs/gnome-vfs-resolve.h: 
+	* libgnomevfs/gnome-vfs-resolve.c (gnome_vfs_resolve_next_address): 
+	* libgnomevfs/gnome-vfs-ssl.c (gnome_vfs_ssl_create): 
+	* libgnomevfs/gnome-vfs-inet-connection.c (gnome_vfs_inet_connection_create):
+	* imported/neon/ne_gnomevfs.c:
+	Renamed gnome-vfs-next-address() to gnome-vfs-resolve-next-address().
+
 === gnome-vfs 2.7.5 ===
 
 Mon Jul 26 16:09:44 2004  Jonathan Blandford  <jrb gnome org>
Index: imported/neon/ne_gnomevfs.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/imported/neon/ne_gnomevfs.c,v
retrieving revision 1.2
diff -u -r1.2 ne_gnomevfs.c
--- imported/neon/ne_gnomevfs.c	22 Jul 2004 04:28:46 -0000	1.2
+++ imported/neon/ne_gnomevfs.c	27 Jul 2004 19:25:17 -0000
@@ -140,7 +140,7 @@
 		gnome_vfs_resolve_reset_to_beginning (addr->handle);
 	}
 
-	if (! gnome_vfs_next_address (addr->handle, &address)) {
+	if (! gnome_vfs_resolve_next_address (addr->handle, &address)) {
 		return NULL;
 	}
 
Index: libgnomevfs/gnome-vfs-inet-connection.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-inet-connection.c,v
retrieving revision 1.19
diff -u -r1.19 gnome-vfs-inet-connection.c
--- libgnomevfs/gnome-vfs-inet-connection.c	21 Jul 2004 17:46:28 -0000	1.19
+++ libgnomevfs/gnome-vfs-inet-connection.c	27 Jul 2004 19:25:18 -0000
@@ -87,7 +87,7 @@
 
 	sock = -1;
 	
-	while (gnome_vfs_next_address (rh, &address)) {
+	while (gnome_vfs_resolve_next_address (rh, &address)) {
 		sock = socket (gnome_vfs_address_get_family_type (address),
 			       SOCK_STREAM, 0);
 
Index: libgnomevfs/gnome-vfs-resolve.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-resolve.c,v
retrieving revision 1.3
diff -u -r1.3 gnome-vfs-resolve.c
--- libgnomevfs/gnome-vfs-resolve.c	20 Jul 2004 18:39:26 -0000	1.3
+++ libgnomevfs/gnome-vfs-resolve.c	27 Jul 2004 19:25:19 -0000
@@ -292,7 +292,7 @@
  * gnome_vfs_resovle_reset_to_beginning:
  * @handle: A #GnomeVFSResolveHandle.
  *
- * Reset @handle so that a following call to gnome_vfs_next_address
+ * Reset @handle so that a following call to gnome_vfs_resolve_next_address
  * will return the first resolved address.
  *
  *
@@ -307,7 +307,7 @@
 }
 
 /**
- * gnome_vfs_next_address:
+ * gnome_vfs_resolve_next_address:
  * @handle: A #GnomeVFSResolveHandle.
  * @address: A pointer to a pointer to a #GnomeVFSAddress.
  * 
@@ -320,8 +320,8 @@
  * Since: 2.8
  **/
 gboolean
-gnome_vfs_next_address (GnomeVFSResolveHandle  *handle,
-				    GnomeVFSAddress       **address)
+gnome_vfs_resolve_next_address (GnomeVFSResolveHandle  *handle,
+						  GnomeVFSAddress       **address)
 {
 	   g_return_val_if_fail (address != NULL, FALSE);
 	   g_return_val_if_fail (handle != NULL, FALSE);
Index: libgnomevfs/gnome-vfs-resolve.h
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-resolve.h,v
retrieving revision 1.2
diff -u -r1.2 gnome-vfs-resolve.h
--- libgnomevfs/gnome-vfs-resolve.h	16 Jul 2004 14:17:04 -0000	1.2
+++ libgnomevfs/gnome-vfs-resolve.h	27 Jul 2004 19:25:19 -0000
@@ -28,13 +28,13 @@
 
 typedef struct GnomeVFSResolveHandle_ GnomeVFSResolveHandle;
 
-GnomeVFSResult gnome_vfs_resolve      (const char              *hostname,
-							    GnomeVFSResolveHandle  **handle);
-gboolean       gnome_vfs_next_address (GnomeVFSResolveHandle   *handle,
-							    GnomeVFSAddress        **address);
+GnomeVFSResult gnome_vfs_resolve              (const char              *hostname,
+									  GnomeVFSResolveHandle  **handle);
+gboolean       gnome_vfs_resolve_next_address (GnomeVFSResolveHandle   *handle,
+									  GnomeVFSAddress        **address);
 void           gnome_vfs_resolve_reset_to_beginning
-                                      (GnomeVFSResolveHandle   *handle);
-void           gnome_vfs_resolve_free (GnomeVFSResolveHandle   *handle);
+                                              (GnomeVFSResolveHandle   *handle);
+void           gnome_vfs_resolve_free         (GnomeVFSResolveHandle   *handle);
 
 G_END_DECLS
 
Index: libgnomevfs/gnome-vfs-ssl.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-ssl.c,v
retrieving revision 1.19
diff -u -r1.19 gnome-vfs-ssl.c
--- libgnomevfs/gnome-vfs-ssl.c	15 Jul 2004 15:32:44 -0000	1.19
+++ libgnomevfs/gnome-vfs-ssl.c	27 Jul 2004 19:25:20 -0000
@@ -207,7 +207,7 @@
 
 	sock = -1;
 	
-	while (gnome_vfs_next_address (rh, &address)) {
+	while (gnome_vfs_resolve_next_address (rh, &address)) {
 		sock = socket (gnome_vfs_address_get_family_type (address),
 			       SOCK_STREAM, 0);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]