Re: [Fwd: [PATCH] Supress eroneous authentications in the SMB module]

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-02-15 at 09:42 +0000, Nielsen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> And now again with the patch...
> 
> - -------- Original Message --------
> Subject: [PATCH] Supress eroneous authentications in the SMB module
> Date: Mon, 14 Feb 2005 18:00:26 -0700
> From: Nielsen <nielsen memberwebs com>
> To: gnome-vfs-list gnome org <gnome-vfs-list gnome org>
> 
> The new authentication code in the SMB module has a prompting issue. Any
> time it encounters a EPERM or EACCES it tries to authenticate and throws
> up a prompt (when no cached authentication is available or it fails).
> 
> This unabashed lust for authentication leads to some problems. For
> example open an SMB share that you only have read-only access to. Now
> try to rename a file. You'll get a prompt for a user name and password
> instead of the expected error message. I guess this could make sense in
> a twisted sort of way but it's probably not what the user is expecting.
> 
> I'd like to get this fixed before Gnome 2.10. Attached is a patch. This
> patch makes the assumption that if we already have a cached connection
> then there's no point in trying to reprompt the user for more
> credentials. Before committing I'd like to see if anyone thinks this
> assumption is an invalid one.

What about the case where there is no cached connection, and you're not
allowed to read the file you're trying to load. In this case, won't it
seem like the login fails instead?

Otherwise i think its a valid assumption.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a gun-slinging Amish cat burglar with no name. She's a psychotic 
foul-mouthed hooker married to the Mob. They fight crime!