Re: [GnomeMeeting-devel-list] [PATCH] removes unneeded begin/end call notification in text-chat

[Damien Sandras <damien sandras it-optics com>]

Le ven 23/01/2004 à 21:36, PUYDT Julien a écrit :
> On ven, 2004-01-23 at 18:57, Damien Sandras wrote:
> > Then you have to create a GObject for the text chat. That's overkill,
> 
> I don't think that's overkill... that's just a different way to organize

Tell me, you haven't read the docs yet to create GObjects? ;)

> things ; it has the advantage that features are better separated, hence
> easier to modify for enhancement.

I agree. That was on my long-term TODO list. The stats drawing area is
particularly well-suited to become a GObject. Same for the preferences
window and for the chat window. For the rest, it is discussable.

I would say we have to put that on the TODO for the 2.00 release as part
of the code improvements.

> 
> > but if you want to do it... That way all structures are internal and
> > private, and destroyed when the widget is destroyed. That could be a
> > nice job to do, and we already have several GObjects in GM. But I vote
> > for > 1.00.
> 
> I wasn't proposing that for 1.00, but after. Say before introducing
> brand-new features (saving the text-chat is in the TODO).
> 

Well, I think working with Craig and Robert on OPAL integration is the
top-priority if we want to make things work in a decent timeline, but I
think we will do things in 3 separate branches :
- the 1.00 branch with bugfixes to the 1.00 release
- the 1.00 devel-branch for that kind of thing
- the experimental branch for OPAL


However, I think that after 1.00 we have to concentrate on OPAL
integration before starting rewriting code that already works.

> > PS: make sure all your patches are committed.
> 
> I erase them only when I have seen them committed. The patch to fix the
> notification in the text-chat is still there (well, of course with
> today's clear history patch)...
> 

I think that your revised version of the notification can go in.
The clear history patch will be committed by me (as I also want to make
sure the GUI looks ok before it is committed and as I had an awful day,
that costed me a lot of wasted time and money).

> Snark
> 
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
-- 
 _      Damien Sandras
(o-     
//\     It-Optics s.a.
v_/_    GnomeMeeting: http://www.gnomemeeting.org/
        FOSDEM 2004:  http://www.fosdem.org
        H.323 phone:  callto:ils.seconix.com/dsandras seconix com