Re: [GnomeMeeting-devel-list] [PATCH] removes unneeded begin/end call notification in text-chat

[PUYDT Julien <julien puydt laposte net>]

On ven, 2004-01-23 at 22:41, Damien Sandras wrote:

> > I don't think that's overkill... that's just a different way to organize
> 
> Tell me, you haven't read the docs yet to create GObjects? ;)

Well, no I haven't, and in fact, I don't really see why it is needed...

Could you remind me why you prefer having a structure filled with
private variables widely available in common.h, rather than the same
variables declared static at the beginning of the right .cpp?

> > things ; it has the advantage that features are better separated, hence
> > easier to modify for enhancement.
> 
> I agree. That was on my long-term TODO list. The stats drawing area is
> particularly well-suited to become a GObject. Same for the preferences
> window and for the chat window. For the rest, it is discussable.

Well, I don't know (yet) how costy a GObject is, but with what I say
above, it's quite simple...

> I would say we have to put that on the TODO for the 2.00 release as part
> of the code improvements.

Indeed, it is definitely not for 1.00 or a version that would be derived
from it.

> Well, I think working with Craig and Robert on OPAL integration is the
> top-priority if we want to make things work in a decent timeline, but I
> think we will do things in 3 separate branches :
> - the 1.00 branch with bugfixes to the 1.00 release
> - the 1.00 devel-branch for that kind of thing
> - the experimental branch for OPAL

Hmmm... devel&experimental will be though to sync... or is OPAL near
enough to openh323 (api-wise) ? Unless the refactoring is made fast
enough, of course.

> However, I think that after 1.00 we have to concentrate on OPAL
> integration before starting rewriting code that already works.

Well, I think it will be easier to refactor then add features, than the
other way round...

> I think that your revised version of the notification can go in.
> The clear history patch will be committed by me (as I also want to make
> sure the GUI looks ok before it is committed and as I had an awful day,
> that costed me a lot of wasted time and money).

I know about your day :-(

My pending-patch list is empty, I think that makes it possible to work
on items of my todo list.

Snark