Re: Better Video Codecs - was Re: [GnomeMeeting-list] ideas..

[Malcolm Caldwell <malcolm caldwell ntu edu au>]

On Sun, 2005-12-11 at 11:50 +0100, Damien Sandras wrote:
> Here is an example :
> http://cvs.gnome.org/viewcvs/gnomemeeting/src/endpoint.cpp?r1=1.378&r2=1.379
> 
> It was in CVS a long time ago.

Would it hurt to put that code back in there?  All it does is call a
function, if a define is defined. 

The actual linking of h323 against ffmpeg etc is were there may or may
not be patent issues.

If the code was in there then it would be easier for people who wanted
to to get this working.  This whole exchange could have been reduced to
follow the instructions at voxgratia, then recompile gnomemeeting.

> 
> 
> Le dimanche 11 décembre 2005 à 00:26 +0000, JGJones a écrit :
> > Sorry to ask but pretty please could you show me what you mean? Example 
> > code?
> > 
> > I've bugger all idea about the programming language that you're using or 
> > anything else like that! :)
> > 
> > Last time I did any programming was many blue moons ago.
> > 
> > SO far my attempts to get it working isn't succeeding very well ie crash 
> > on compiling when it's on endpoint.cpp esp the section that I'm editing!
> > 
> > Thanks again.
> > 
> > JGJones
> > 
> > Y Ddraig Goch a ddyry Gychwyn
> > Cymru am byth
> > 
> > BSL Video-Group:
> > http://mail.bluecheetah.biz/mailman/listinfo/bsl-vgroup_bluecheetah.biz
> > 
> > Deaf-UK Technology Wiki
> > http://bslvgroup.mrdini.com/wiki/Main_Page
> > 
> > There are 10 kinds of people in this world: 1) nerds and 2) normals.
> > 
> > 
> > Damien Sandras wrote:
> > > I wouldn't change it, but add "above"...
> > > 
> > > 
> > > Le samedi 10 décembre 2005 à 18:04 +0000, JGJones a écrit :
> > > 
> > >>Just to confirm:
> > >>
> > >>   /* Add video capabilities */
> > >>   if (video_size == 1) {
> > >>
> > >>     if (autoStartTransmitVideo && !autoStartReceiveVideo) {
> > >>
> > >>       /* CIF Capability in first position */
> > >>       AddCapability (new H323_H261Capability (0, 1, FALSE, FALSE, 6217));
> > >>       AddCapability (new H323_H261Capability (1, 0, FALSE, FALSE, 6217));
> > >>     }
> > >>     else {
> > >>
> > >>       /* CIF Capability in first position */
> > >>       SetCapability (0, 1, new H323_H261Capability (0, 1, FALSE, FALSE, 
> > >>6217));
> > >>       SetCapability (0, 1, new H323_H261Capability (1, 0, FALSE, FALSE, 
> > >>6217));
> > >>     }
> > >>   }
> > >>   else {
> > >>
> > >>     if (autoStartTransmitVideo && !autoStartReceiveVideo) {
> > >>
> > >>       AddCapability (new H323_H261Capability (1, 0, FALSE, FALSE, 6217));
> > >>       AddCapability (new H323_H261Capability (0, 1, FALSE, FALSE, 6217));
> > >>     }
> > >>     else {
> > >>
> > >>       SetCapability (0, 1, new H323_H261Capability (1, 0, FALSE, FALSE, 
> > >>6217));
> > >>       SetCapability (0, 1, new H323_H261Capability (0, 1, FALSE, FALSE, 
> > >>6217));
> > >>     }
> > >>   }
> > >>}
> > >>
> > >>Change to:
> > >>
> > >>   /* Add video capabilities */
> > >>   if (video_size == 1) {
> > >>
> > >>     if (autoStartTransmitVideo && !autoStartReceiveVideo) {
> > >>
> > >>       /* CIF Capability in first position */
> > >>AddCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, 
> > >>maxbps));
> > >>AddCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, 
> > >>maxbps));
> > >>     }
> > >>     else {
> > >>
> > >>       /* CIF Capability in first position */
> > >>SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, 
> > >>maxbps));
> > >>SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, 
> > >>maxbps));
> > >>     }
> > >>   }
> > >>   else {
> > >>
> > >>     if (autoStartTransmitVideo && !autoStartReceiveVideo) {
> > >>
> > >>AddCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, 
> > >>maxbps));
> > >>AddCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, 
> > >>maxbps));
> > >>     }
> > >>     else {
> > >>
> > >>SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, 
> > >>maxbps));
> > >>SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, 
> > >>maxbps));
> > >>     }
> > >>   }
> > >>}
> > >>
> > >>JGJones
> > >>
> > >>Y Ddraig Goch a ddyry Gychwyn
> > >>Cymru am byth
> > >>
> > >>BSL Video-Group:
> > >>http://mail.bluecheetah.biz/mailman/listinfo/bsl-vgroup_bluecheetah.biz
> > >>
> > >>Deaf-UK Technology Wiki
> > >>http://bslvgroup.mrdini.com/wiki/Main_Page
> > >>
> > >>There are 10 kinds of people in this world: 1) nerds and 2) normals.
> > >>
> > >>
> > >>Damien Sandras wrote:
> > >>
> > >>>Le vendredi 09 d�cembre 2005 � 18:52 +0000, JGJones a �crit :
> > >>>
> > >>>
> > >>>>...ok all that hassle...
> > >>>>
> > >>>>when going to a dir, I used =../<dir> but seeing that you used full 
> > >>>>paths, so I did that and it found them...
> > >>>>
> > >>>>After all that hell of a hassle I now have OpenH323 installed with the 
> > >>>>patched ffmpeg
> > >>>>
> > >>>>Lesson learned - use full paths next time!
> > >>>>
> > >>>>Now I need to compile and install GnomeMeeting. What do I do with this one?
> > >>>>
> > >>>
> > >>>
> > >>>Simple and easy :)
> > >>>
> > >>>Edit src/endpoint.cpp, find AddVideoCapabilities, then follow "Modifying
> > >>>applications" in http://www.voxgratia.org/docs/h263_codec.html.
> > >>>
> > >>>It will be something like :
> > >>> if (videoSize == 1)
> > >>>{                                                         
> > >>>        SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, maxbps)); 
> > >>>        SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, maxbps));
> > >>>      } else {                                                                     
> > >>>        SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 1, 0, 0, 0, maxbps)); 
> > >>>        SetCapability(0, 1, new  H323_RFC2190_H263Capability(0, 0, 2, 0, 0, maxbps)); 
> > >>>      }      
> > >>>
> > >>>Of course, you will have to tweak it a bit :)
> > >>
> > >>_______________________________________________
> > >>GnomeMeeting-list mailing list
> > >>GnomeMeeting-list gnome org
> > >>http://mail.gnome.org/mailman/listinfo/gnomemeeting-list
> > _______________________________________________
> > GnomeMeeting-list mailing list
> > GnomeMeeting-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnomemeeting-list