Re: Gnumeric 0.68 to be released on July 17

[Etsushi Kato <ekato ees hokudai ac jp>]

On Sun, Jul 15, 2001 at 07:38:59PM +0200,
"Almer S. Tigelaar" <almer gnome org> wrote:

> > There seems to be a little bug in Text File import (customizable)
> > in current gnumeric.
>
> The problem was twofold :
> 1) The upper bound on the maximum number of lines to import was ignored.

I see.  I didn't notice that.  

> 2) The last lines was not parsed by a mistake when setting the upper bound
> for the previews.

But even if I don't set number for upper bound, last line is not parsed
in preview dialog.

With following change, the last line appears in preview dialog.

--- stf-parse.c Wed Jul 11 12:47:55 2001
+++ stf-parse.c Mon Jul 16 14:33:01 2001
@@ -617,11 +617,11 @@
                                return NULL;
                }
                
+               l = g_list_append (l, r);
                if (parseoptions->parselines != -1)
                        if (row > parseoptions->parselines)
                                break;
 
-               l = g_list_append (l, r);
                src.position++;
        }


Thanks,
-- 
Etsushi Kato
ekato ees hokudai ac jp