Re: 1.0.5 compilation error

[Gregory Margo <gmargo pacbell net>]

On Sun, Mar 10, 2002 at 04:15:11PM -0500, Jody Goldberg wrote:
> Looks like a potentially missing file in the docs build.  Not
> terribly important please ignore it.  I'll try and get all the kinks
> worked out for 1.0.6 next month.


There is a related not-terribly-important bug in the documentation directory.
At least two generated files are also checked into CVS.
(functions.sgml, func.defs)
IMO, generated files should not be in the repository.

Since all good programmers always check out source trees in read-only mode
(cvs -r, or CVSREAD environment variable), and the shell generally balks
at overwriting a read-only file, the compilation will fail without
first removing the target.

I use the following patch on doc/C/Makefile.am; it could apply to the
other doc Makefile.am files.  The func-list.sgml patch is not strictly
neccessary; just included for niceness.  The patch does not apply
directly to the development tree, because doc stuff got moved around.


Index: Makefile.am
===================================================================
RCS file: /cvs/gnome/gnumeric/doc/C/Makefile.am,v
retrieving revision 1.37.2.1
diff -u -r1.37.2.1 Makefile.am
--- Makefile.am 2002/02/21 07:34:20     1.37.2.1
+++ Makefile.am 2002/03/17 19:02:13
@@ -326,14 +326,17 @@
        $(PERL_FILES)
 
 functions.sgml: func-list.sgml func-header.sgml func-footer.sgml
+       cd $(srcdir) && rm -f functions.sgml
        cd $(srcdir) && cat func-header.sgml func-list.sgml func-footer.sgml > functions.sgml
 
 func-list.sgml: func.defs make-func-list.pl
+       cd $(srcdir) && rm -f func-list.sgml
        cd $(srcdir) && perl make-func-list.pl func.defs > func-list.sgml
 
 #func-index.sgml: func.defs make-func-index.pl
 #      cd $(srcdir) && perl make-func-index.pl func.defs > func-index.sgml
 
 func.defs: 
+       cd $(srcdir) && rm -f func.defs
        gnumericdir=`cd $(top_builddir)/src && pwd`; \
        cd $(srcdir) && $$gnumericdir/gnumeric --dump-func-defs=func.defs

-- 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Gregory H. Margo
Home: gmargo yahoo com   gmargo pacbell net
Work: gmargo cashcow com