Re: Plans for 1.3/1.4

[Raja R Harinath <harinath cs umn edu>]

Tor Lillqvist <tml@iki.fi> writes:
> Owen Taylor writes:
>  >  4) Integration of Tor Lillqvist's Win32 port.
> 
> Any ideas on how to organise the window-system specific versions of
> GDK in the source tree? Apparently CVS doesn't handle renaming of
> directories nicely, so it would be easiest to keep the current (X11)
> version in gtk+/gdk, and make a new directory gtk+/gdk-win32 for the
> Win32 version.

I think it would be nicer to call the directory gtk+/gdk/win32 --
i.e. a `win32' subdir for gdk.  

> Another thing: (I asked about this on gimp-developer, only one reply
> which supported that verbose form.) What would be the best feature
> test macros to use for testing X11 vs Windows GDI API (or BeOS, or
> Mac, whetever)? I now use X_DISPLAY_MISSING (which autoconf seems to
> support, at least to some extent) and WINDOWS_DISPLAY.
> 
> Would it be cleaner (more orthogonal) to use something like
> 	#if GDK_WINDOWING_API == GDK_WINDOWING_API_X11
> 	#elif GDK_WINDOWING_API == GDK_WINDOWING_API_WIN32
> 	#elif GDK_WINDOWING_API == GDK_WINDOWING_API_BEOS
> 
> etc? (Or is that too verbose?) (There is not much code in gtk+/gtk
> that needs conditional compilation.)

Can't you just define one of GDK_WINDOWING_API_{X11,WIN32,BEOS}, so
that you can say

        #if defined G_W_A_X
        #elif defined G_W_A_W
        #elif defined g_W_A_B
        
- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash