Re: Outstanding GTK+ patches

[Lars Hamann <lars gtk org>]

On Fri, Feb 18, 2000 at 07:18:45PM -0500, Owen Taylor wrote:

> Here is the (embarrassingly long) list of outstanding patches
> on gtk.org. I've roughly classed them by effort they take
> to be applied and whether I think they should be applied. 
> The notes below were written rather quickly, so I apologize
> if they are cryptic in places. If you want more details on
> any of the notes below, let me know.


> gtk-adrian-990224-0
> 
>  Adds "shadow type" to scrolled-window, removing the need for
>  widgets like GtkViewport and GtkClist to draw their own shadows.
>  Also allows adding shadows to the Scrolled-Window + Layout
>  combination nicely. Should go in 1.3.

I'm a bit unsure whether that patch should really go in.
While it may be the "normal case" to add viewports, text widgets
and clists to scrolled windows, there are enough places where
text widgets for example work without scrolled windows. In those
cases the developers have to add their frameless widgets to a 
gtk_frame. That looks a bit inconsistent too. We still have
a few set_shadow_type functions afterwards. So maybe it would
be better to make gtk_scrolled_window at least a successor of
gtk_frame ?
Another question is, how far do you want to go ?
Remove only the frame of viewports and clist ? In that case
gtktext would be a special case when adding to a scrolled_window.
Also remove the frame of gtk_text ? ... So why not remove the
frame of gtk_entry ?

> gtk-guy-990901-0
> 
>  Adds a tail pointer to GtkCList to make appends linear. It
>  might be better to just convert the linear list to an array?

I've applied the patch, it looks good. Switching to an array
would cause a massive rewrite of gtkctree - it would be better
to write complete new column widgets in that case.

bye,
  Lars