Outstanding GTK+ patches

[Owen Taylor <otaylor redhat com>]

Here is the (embarrassingly long) list of outstanding patches
on gtk.org. I've roughly classed them by effort they take
to be applied and whether I think they should be applied. 
The notes below were written rather quickly, so I apologize
if they are cryptic in places. If you want more details on
any of the notes below, let me know.

I'm posting this here partly as a reference for myself and
the other core GTK+ developers, and partly so that those who
have submitted patches don't feel that there patches have
been completely forgotten. Hopefully, we can go through all
these patches in the next few weeks and either apply them
or get a response out to the author letting them know the
status of their patch.

Regards,
                                        Owen

Patches that should be applied
==============================

gtk-herzog-990617-0

 Adds gdk_draw_bitmap() to GDK. Should be applied.

glib-dbsears-990923-0

 Optimization for g_node_first_child. Looks good to apply.

gtk-adrian-990224-0

 Adds "shadow type" to scrolled-window, removing the need for
 widgets like GtkViewport and GtkClist to draw their own shadows.
 Also allows adding shadows to the Scrolled-Window + Layout
 combination nicely. Should go in 1.3.

gtk-enf-990513-1

 Make GtkText use IBeam rather than arrow for the mouse cursor.

gtk-enf-990512-0

 Changes the repeat on the scrollbar arrows to have an initial 
 delay.

gtk-martin-991025-0

 Spelling fixes for comments and docs.

gtk-pauls-990307-0

 Updates for nl.po file. Should be applied.


Fixes requiring further evaluation
==================================

glib-guy-990920-0

 Adds -R to the output of glib-config; I think one of the GNU info
 pages has some manifesto as to why -R is evil... but otherwise
 might be OK. (Would require the corresponding change to gtk 
 to be useful)

glib-hpux-990317-0

 Patch to remove some warnings on HP/UX. The part of this 
 which get rid of implicit casts between gpointer and 
 function pointers should definitely be applied. #warning
 is no longer found in glib. The #include <time.h> part also should
 be unecessary since we simply include a forward declaration
 for struct tm now.

gtk-Janet_Davis-990617-0

 Changes the way GtkViewport does size allocation by removing
 some padding in most cases. Might be good to apply? Needs
 further evaluation.

gtk-a-higuti-990523-0

 Some changes to sending focus in events to deal with oddities
 in XIM. Not clear if it is "correct" or not, though it obviously
 does solve problems.

gtk-leitner-990826-0

 Changes ordering so has_selection is already set during the 
 "delete_text" callback. Neither this nor what is in GTK+
 now look correct to me, since the delete_text callback
 could refuse to delete the text.

gtk-hpux-990317-0

 Warnings fixups on HP/UX. May have some valid patches inside 
 of it, though a lot of the stuff there is a bit questionable.

gtk-lytles-000120-0

 Changes xoffset and yoffset in GtkLayout to be gint instead
 of guint. Does it make sense for them to be negative?
 Claim in README of bugs from this, but no information about
 how to reproduce these bugs.

gtk-rao-990117-0

 Makes exiting from a GTK+ program thread safe.

gtk-rdm-990711-0

 Fixes to GtkText.


Reasonable looking feature additions
====================================

glib-dbsears-990920-0

 Copy function for GNode structures. Could be useful. Very small
 and compact.

glib-jmayer-000212-0
glib-jmayer-000212-1

 Patches to add a GIntSpan data type to GLib. These are compactly
 represented integer sets, much like the GNUS range data
 type. This might be useful for people...

glib-sandmann-990305-0.README
glib-sandmann-990305-1.README
glib-sandmann-990305-2.README

 Splay tree implementation. Require someone deciding the "what binary
 trees do we want" questions. Do we want a generic binary
 tree base-class with implementations?

glib-sandmann-990808-0

 Implements g_tree_lookup_range. Basically returns a GSlist of 
 all nodes in a tree in a certain range. Might be useful.

gtk-bar-990524-0

 Adds "operation" when setting the shapes for a widget so you
 can OR, etc, the shape with the existing shape. Might be
 OK to apply though it should use GdkFunction enumeration.

gtk-enf-990511-0

 Adds blinking cursor to GtkEntry.

gtk-enf-990512-1
 
 Changes scrolled windows and Clist to scroll '1 page - 1 line'
 instead of 0.5 page.

gtk-guy-990901-0

 Adds a tail pointer to GtkCList to make appends linear. It
 might be better to just convert the linear list to an array?

gtk-hniksic-990224-0

 Considers all tooltips within a single Tooltips to be in a
 single "group" and removes the delay when popping up a tooltip for
 another widget in the same group immediately after exiting another
 widget in the group.

 This is incompatible with existing practice where people
 just use a single tooltips object for everything, but probably
 is a desirable UI enhancement. 

gtk-hovinen-991213-1

 Changes the way the focus indicator is drawn for buttons to be
 windowsesque. I don't see applying this unless we make the 
 focus rectangle be a dotted rectangle for everything, and also
 change the default to be drawn in the windows fashion 
 But that would break all the themes.Non-context diff!

gtk-maher-990922-0

 Adds a MRU list to GtkFileSelection.

gtk-nodatadj-990318-0

 Adds gtk_clist_get_selection(), gtk_clist_get_nth_selection().
 I don't think the latter function is useful, but the former
 addition would remove a common question. 

gtk-rdm-990712-0

 Mixes together gtk-rdm-990711 plus:

 Changes GDK_RELIEF_HALF to display relief only on prelight
 Changes GDK_RELIEF_NONE to never display relief.

 This change is almost certainly correct, though it might
 break existing programs.  


Obsolete patches
================

gtk-enf-990513-0

 Rationalizes GTK+ options to all accept either --value=option
 or --value option. The gdk_arg_* stuff in 1.3 also fixes this,
 so this is probably obsolete.

gtk-ethgen-000119-0

 Fix segfault with GtkItemFactory. Was fixed in CVS some time
 between 1.2.6 and submission of this patch.

gtk-jira-990214-0

 cs.po. Looks like we have this in place now.

gtk-kenelson-990502-0
 
 Makes window/drawable subsitutions. No README. I think all 
 this stuff is now properly changed in the 1.3 branch.

gtk-martinmv-991210-0

 Adds some warnings for questionable/invalid allocations. We already
 now do that now, though in a somewhat different way. (This patch
 changes GtkAllocation to have signed coordinates)


Patches probably not suitable to be applied
===========================================

glib-agayev-990629-0

 Minor modifications to g_slist_reverse(). Modifying parameters
 in a function is definitely acceptable. Also has suggestion about
 removing an extra temporary, but would make no significant differnence.

glib-jspaans-991812-0

 Some fiddling with the Julian data formula in GLib. Seems to 
 be no advantage to applying this patch ... since it would
 diverge the (complicated) formula from the referenced source
 without any compelling performance advantage.

glib-oberzalek-991111-0
glib-oberzalek-991111-1

 Patches to add some basic-like string functions to GLib. Mostly,
 these are just renames of existing stdc functions... 
 not exactly within the normal domain of GLib. 

gdk_bitmap_create_from_pixmap-990507

 Color->alpha function for pixmaps. I don't think this belongs in GDK;
 you really should be using GdkPixbuf and doing this _before_ you
 create your pixmap on the display rather than pulling the information
 back from the X server. The implementation here doesn't even work
 properly for pseudo-color displays.
  
gtk-fotang-990615-0.xrm.README
gtk-fotang-990615-0.xrm.tar

 Allows GTK+ applications to access X resources. I don't think
 this belongs in GTK+. If you want X resources, use XLib within
 your GTK+ application.

gtk-hovinen-991214-1

 Adds a blinking cursor to GtkEntry. Also makes insertion point
 cursor a "I-beam" Non-context diff! (Blinking part duplicate of
 gtk-enf-990513-1, having the insertion cursor be a I-beam seems
 cluttered to me; Motif does it that way, Windows doesn't)

gtk-redhog-990911-0
gtk-redhog-991111-0

 Blippiness ... scheme to have menus and toolbars vanish when
 window looses focus. Maybe could be done as a module?

gtk-plex-990803-patch
 
 GtkMagic ... fancy scheme for theme server/client mechanism.
 Does not belong in GTK+, but patches to make it possible to 
 do as a module would be accepted.

gtk-wglas-990907-0

 Tries to make GtkLayout cross platform by adding fallback
 implementation on windows in terms of GDK primitive. Not the
 correct thing to do, since GtkLayout is just there to fix problems 
 in X that don't exist in windows. We'll have some better
 fix for making GtkLayout cross-platform for this at the GDK
 level in 1.3.


Misc patches
============

gtk-dking-990423-0.new
gtk-dking-990507-0

 Major additions to the texi reference materials (!). Need to redirect
 the author at the RDP and see if he is interested in integrating
 any of his work into that.

gtk-eloy-990301-0

 Update to the pl.po file. Looks like we now have a complete 
 translation, thought some of the strings we now have are a bit
 different from the ones here.