Re: Bug#14412: g_list_find_custom inconsistent with GCompareFunc

[Sebastian Wilhelmi <wilhelmi ira uka de>]

Hi Tim, 

[[ CC-ed to Owen because of pango: read on]]

> > Yes, it's done. A quick grep through gtk+ revealed some other locations of
> > false GCompareFunc and false 'compare' though. You might want to check
> > (I'm not going to touch gtk+, unless 'ordered' to do so.... ;-)
> 
> hm, if you had sent a list of the apropriate cases and suggested changes,
> i could give required "order" ;)))
> i.e. if you feel like compiling it and sending it here,
> that'd be apprechiated ;)

Here is the patch (diff -b, so white space changes are not inside, which
means, that if you approve, it's best, if I'm committing it to commit the
reindentation fixes as well). It basically renames some (only internal!)
functions from _cmp to _equal. But one problem is still there:

Pango has the following functions:

gboolean pango_attribute_compare        (const PangoAttribute *attr1,
                                         const PangoAttribute *attr2);
gboolean pango_font_description_compare (const PangoFontDescription  *desc1,
                                         const PangoFontDescription  *desc2);

and the member 'compare' in the PangoAttrClass,

which all are rather 'equal'-functions in the (admittedly new) GLib-sense and
it would make sense to change that now, that the API hasn't stabilized yet.

I would make a patch, if you want.

Bye,
Sebastian
-- 
Sebastian Wilhelmi                   |            här ovanför alla molnen
mailto:wilhelmi ira uka de           |     är himmlen så förunderligt blå
http://goethe.ira.uka.de/~wilhelmi   |