Re: Bug#14412: g_list_find_custom inconsistent with GCompareFunc
- From: Tim Janik <timj gtk org>
- To: Sebastian Wilhelmi <wilhelmi ira uka de>
- Cc: Gtk Development List <gtk-devel-list gnome org>
- Subject: Re: Bug#14412: g_list_find_custom inconsistent with GCompareFunc
- Date: Mon, 30 Oct 2000 16:02:23 +0100 (CET)
On Mon, 30 Oct 2000, Sebastian Wilhelmi wrote:
> > please go ahead and on the way check other usages of *compare* as well.
> > basically, "compare" should return results, and be only used in contexts,
> > where something like this is desired:
> > /* helper macro to avoid signed overflow for value comparisions */
> > #define G_BSEARCH_ARRAY_CMP(v1,v2) ((v1) < (v2) ? -1 : (v1) > (v2) ? 1 : 0)
>
> Yes, it's done. A quick grep through gtk+ revealed some other locations of
> false GCompareFunc and false 'compare' though. You might want to check (I'm
> not going to touch gtk+, unless 'ordered' to do so.... ;-)
hm, if you had sent a list of the apropriate cases and suggested changes,
i could give required "order" ;)))
i.e. if you feel like compiling it and sending it here,
that'd be apprechiated ;)
---
ciaoTJ
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]