Re: gdk_pixbuf_loader_write and short files



"Matthias Clasen" <matthiasc poet de> writes:
> Havoc, looking at the code of gdk_pixbuf_loader_close, I found that
> it already does as you have outlined below.  So it turns out that the
> problems I have seen are really just bugs in gtk-pixbuf/test-loader.c
> and demos/testpixbuf.c which don't use the loader API as documented.
> 
> Here is a patch to fix the two. For testpixbuf I have simply removed the
> "After progressive load" window, which seems to be relatively pointless
> as it will always show exactly the same as the "Progressive" window.
> For test-loader, I have made it notice errors at close time so that you can
> now have tests on short files fail (before this change, good loaders would
> fail on invalid short files, but test-loader would ignore the error coming
> out
> at close time.)
> 
> OK to commit ?
> 

I think you forgot to attach the patch, but the changes sound
correct. ;-)

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]