Re: GIOChannel diff committed

[Hans Breuer <hans breuer org>]

At 08:38 21.07.01 -0700, Ron Steinke wrote:
>
>Hans Breuer <hans breuer org> writes:
>>
>> At 13:22 20.07.01 -0700, Ron Steinke wrote:
>> >	I've committed the big GIOChannel diff I had. This goes a long
>> >way towards getting the new GIOChannel API working. Additionally,
>> >with any luck, the win32 implementation should now compile
>> >(win32 developers, please confirm). I'm eagerly awaiting the bug reports.
>> >
>> I've just commited a first implementation. iochannel-test runs, at least
once:
>> D:\devel\my-gtk\glib\tests>iochannel-test
>
>Looking at your implementation of io_get_flags(), I see that
>you're setting G_IO_FLAG_IS_[READABLE,WRITEBLE,SEEKABLE] in
>the win32 code. This is unnecessary, as these flags are
>set in the calling function g_io_channel_get_flags().
>
Should I change the is_*able flags than, if the underlying system
call gives a change to these flags ? (Appears to be a little less
obvious to me).

	Hans
-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to 
get along without it.                -- Dilbert