Re: GtkLabel patch
- From: Havoc Pennington <hp redhat com>
- To: Tim Janik <timj gtk org>
- Cc: Alexander Larsson <alla lysator liu se>, Gtk+ Developers <gtk-devel-list gnome org>
- Subject: Re: GtkLabel patch
- Date: 28 Feb 2001 20:24:40 -0500
Tim Janik <timj gtk org> writes:
> > @@ -119,24 +128,80 @@ gtk_label_get_type (void)
> > static void
> > gtk_label_class_init (GtkLabelClass *class)
> > {
> > - GObjectClass *gobject_class = G_OBJECT_CLASS (class);
> > + GObjectClass *gobject_class;
> > GtkObjectClass *object_class;
> > GtkWidgetClass *widget_class;
> >
> > + gobject_class = (GObjectClass*) class;
> > object_class = (GtkObjectClass*) class;
> > widget_class = (GtkWidgetClass*) class;
>
> he, there was a reason that i put a G_OBJECT_CLASS() cast there originally.
> actually, all class assignments should use the provided casting macros instead
> of direct c casts, it's the same as for widget casts, i.e. they do additional
> checking for debugging code.
>
That is just pointless slowness, there's no way on earth that
typecheck will ever fail.
Havoc
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]