Re: more patches



Havoc Pennington <hp redhat com> writes:

> >  gtk_entry_set_activate_action (GtkEntry         *entry, 
> >                                 GtkActivateAction action);
> > 
> >  GTK_ACTIVATE_NONE
> >  GTK_ACTIVATE_DEFAULT_WIDGET
> > 
> > Even though the effect is the same, it somehow seems clearer
> > to me. (Mostly, I just don't like the name 'set_activate_default'
> > very much.)
> > 
> 
> I don't like set_activate_default() too much either, but I find the
> enum kind of more confusing than a bool, if there's only one possible
> setting. It adds an extra concept to the API and an extra
> cross-reference you have to follow in the docs. So that's why I didn't
> go with the enum option.
> 
> Would rather someone think of a better name...

After some discussion, Havoc and I agreed to stick with the boolean
and go with:

 gtk_entry_set_activates_default()

Regards,
                                        Owen




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]