Re: Patch: Bug 50278



Mike Kestner <mkestner enteract com> writes:  
> +static void
> +adjustment_value_changed_cb (GtkAdjustment *adj, GtkSpinButton *spin)
> +{
> +  gtk_signal_emit (GTK_OBJECT (spin), spinbutton_signals[VALUE_CHANGED]);
> +}

There's already a gtk_spin_button_value_changed callback in
gtkspinbutton.c, should probably add this there next to the emission
of the OUTPUT signal.

> +
> +  gtk_signal_connect (GTK_OBJECT (adjustment), "value_changed",
> +		      GTK_SIGNAL_FUNC (adjustment_value_changed_cb), 
> +		      spin_button);
> +

So then this goes away of course.

The rest of it looks sane to me, but should wait a bit for more
comments before commiting.

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]