Re: patch to fix module loading

[Owen Taylor <otaylor redhat com>]

jacob berkman <jacob ximian com> writes:

> this is an obvious patch, let me know if it's ok to commit.

Yes, go ahead.

Thanks,
                                        Owen

> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gtk+/ChangeLog,v
> retrieving revision 1.2533
> diff -u -r1.2533 ChangeLog
> --- ChangeLog	2001/11/03 23:26:01	1.2533
> +++ ChangeLog	2001/11/04 19:52:59
> @@ -1,3 +1,8 @@
> +2001-11-04  jacob berkman  <jacob ximian com>
> +
> +	* gtk/gtkmain.c (find_module): don't free the module name until
> +	after we load the module
> +
>  2001-11-04  Tor Lillqvist  <tml iki fi>
>  
>  	* gtk/gtkimmodule.c: Can't include gtkprivate.h (I added the
> Index: gtk/gtkmain.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkmain.c,v
> retrieving revision 1.182
> diff -u -r1.182 gtkmain.c
> --- gtk/gtkmain.c	2001/11/02 01:00:40	1.182
> +++ gtk/gtkmain.c	2001/11/04 19:52:59
> @@ -327,8 +327,9 @@
>        
>        if (g_file_test (module_name, G_FILE_TEST_EXISTS))
>  	{
> +	  module = g_module_open (module_name, G_MODULE_BIND_LAZY);
>  	  g_free (module_name);
> -	  return g_module_open (module_name, G_MODULE_BIND_LAZY);
> +	  return module;
>  	}
>        
>        g_free (module_name);