Re: patch #61389 (clicking disabled menu items closes menu)

[Owen Taylor <otaylor redhat com>]

Kristian Rietveld <kristian planet nl> writes:

> Hello,
> 
> Appended is a patch for bug #61389 (clicking disabled menu items closes
> menu). The fix is pretty straightforward. ChangeLog:
> 
> Fri Nov 23 17:14:57  Kristian Rietveld  <kristian planet nl>
> 
> 	* gtk/gtkmenushell.c: don't deactivate menu when menu_item isn't
> 	sensitive.
> 
> Ok to commit?

Looks fine (well, as much as I still understand the logic in
that function.) Go ahead.

Regards,
                                        Owen

> Index: gtkmenushell.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkmenushell.c,v
> retrieving revision 1.48
> diff -u -r1.48 gtkmenushell.c
> --- gtkmenushell.c	2001/11/17 23:28:50	1.48
> +++ gtkmenushell.c	2001/11/23 16:09:20
> @@ -469,6 +469,8 @@
>  		  return TRUE;
>  		}
>  	    }
> +	  else if (menu_item && !GTK_WIDGET_IS_SENSITIVE (menu_item))
> +	    deactivate = FALSE;
>  	  else if (menu_shell->parent_menu_shell)
>  	    {
>  	      menu_shell->active = TRUE;