Re: GNOME CVS: gtk+ tml

[Tor Lillqvist <tml iki fi>]

jacob berkman writes:
 > this (or a related) commit broke the build:
 > 
 > automake: gdk/Makefile.am: warning: automake does not support
 > libgdk_win32_1_3_la_LDFLAGS being defined conditionally
 > make[1]: *** [distdir] Error 1

Does this necessarily mean that something is broken? I get *lots* of
warnings like that (from stuff I haven't touched) all the time from
automake in several places in Pango and GTK+, and have guessed that
this is just because I use a "too new" automake (1.5a) than that used
by most developers, that has tighter checks... See below.

Yes, these warnings (errors?) are irritating, you have to run "make
Makefile" twice after editing Makefile.am, for instance. (The first
time the automake run claims to fail (but does in fact produce a
Makefile.in), the second time then runs config.status to produce the
Makefile.)

 > i've committed the following patch which i think works (it at least
 > builds on unix), please fix it if it's broken on win32.

Your patch should work, but is not "right" in the general case. What
if there were several conditionally built .la files in a Makefile.am,
and they needed different conditional LDFLAGS? One cannot then use a
single LDFLAGS for those.

Running automake 1.5a in current gtk+ gives the errors (warnings)
below, but it still produces Makefile.in files that, to the best of my
knowledge, work as expected.

demos/gtk-demo/Makefile.am:24: `demos' includes configure substitution ` STRIP_BEGIN@', and is referred to from `gtk_demo_SOURCES': configure substitutions not allowed in _SOURCES variables
demos/gtk-demo/Makefile.am:24: `demos' includes configure substitution ` STRIP_END@', and is referred to from `gtk_demo_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk-pixbuf/Makefile.am:259: libgdk_pixbuf_1_3_la_DEPENDENCIES was already defined in condition TRUE, which implies condition BUILD_DYNAMIC_MODULES_TRUE
  libgdk_pixbuf_1_3_la_DEPENDENCIES (User, where = 259) =
  {
    TRUE => $(builtin_objs) $(gdk_pixbuf_def)
  }
gdk-pixbuf/Makefile.am:259: libgdk_pixbuf_1_3_la_DEPENDENCIES was already defined in condition TRUE, which implies condition BUILD_DYNAMIC_MODULES_FALSE
  libgdk_pixbuf_1_3_la_DEPENDENCIES (User, where = 259) =
  {
    TRUE => $(builtin_objs) $(gdk_pixbuf_def)
    BUILD_DYNAMIC_MODULES_TRUE => pixops/libpixops.la
  }
gdk-pixbuf/Makefile.am:250: `libgdk_pixbuf_1_3_la_SOURCES' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgdk_pixbuf_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk-pixbuf/Makefile.am:250: `libgdk_pixbuf_1_3_la_SOURCES' includes configure substitution ` STRIP_END@', and is referred to from `libgdk_pixbuf_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgdk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgdk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgdk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgdk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgdk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gdk/Makefile.am:142: `gdk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgdk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_linux_fb_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:552: libgtk_win32_1_3_la_DEPENDENCIES was already defined in condition USE_WIN32_TRUE, which implies condition OS_WIN32_FALSE USE_WIN32_TRUE
  libgtk_win32_1_3_la_DEPENDENCIES (User, where = 552) =
  {
    USE_WIN32_TRUE => $(gtk_def) $(gtk_win32res_lo)
  }
gtk/Makefile.am:552: libgtk_win32_1_3_la_DEPENDENCIES was already defined in condition USE_WIN32_TRUE, which implies condition OS_WIN32_TRUE USE_WIN32_TRUE
  libgtk_win32_1_3_la_DEPENDENCIES (User, where = 552) =
  {
    OS_WIN32_FALSE USE_WIN32_TRUE => 
    OS_WIN32_FALSE USE_WIN32_FALSE => 
    USE_WIN32_TRUE => $(gtk_def) $(gtk_win32res_lo)
  }
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_win32_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:395: `gtk_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_BEGIN@', and is referred to from `libgtk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables
gtk/Makefile.am:401: `gtk_plug_c_sources' includes configure substitution ` STRIP_END@', and is referred to from `libgtk_x11_1_3_la_SOURCES': configure substitutions not allowed in _SOURCES variables

Cheers,
--tml