Re: KEYNAV:GtkTextView



"Padraig O'Briain" <Padraig Obriain Sun COM> writes: 
> Can I commit this?

Yes, looks good.

> +      if (count < 0)
> +        gtk_text_iter_backward_lines (&newplace, -count);
> +      else if (count > 0)
> +        gtk_text_iter_forward_lines (&newplace, count);
> +      gtk_text_iter_set_line_offset (&newplace, 0);
>        break;

forward_lines takes a negative count to go backward, so I think you
could just do this and avoid the if statement:

 gtk_text_iter_forward_lines (&newplace, count);

(there's preexisting code in there that could also be simplified this
way)

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]