Re: #59803: patch

[Owen Taylor <otaylor redhat com>]

Kristian Rietveld <kristian planet nl> writes:

> Hi,
> 
> Appended patch fixes #59803 (GtkEditable needs signals) with option 1)
> from the possibilities in my previous mail. ChangeLog:
> 
> Sun Sep 23 18:35:39 2001  Kristian Rietveld  <kristian planet nl>
> 
>         * gtk/gtkeditable.[ch]: move insert_text and delete_text virtual
>         functions to do_insert_text and do_delete_text, add signals
>         insert_text, delete_text and changed
> 
>         * gtk/gtkentry.[ch]: remove signals insert_text, delete_text
>         and changed. Updates to match new situation.
> 
>         * gtk/gtkspinbutton.c: updates to match new situation
> 
>         Fixes bug #59803
> 
> Ok to commit?

This looks very good except for one thing -- you missed GtkOldEditable.

If you fix that the same way as GtkEntry, this should be ready to 
commit, but I think it would be best to hold off on this patch
until after we get the GNOME 2.0 platform alpha out in the middle
of the week.

Thanks,
                                        Owen