Re: Some GValue'ization of GtkBinding

[Tim Janik <timj gtk org>]

On Tue, 15 Jan 2002, Owen Taylor wrote:

> Hi Tim,
> 
> The following is a patch to convert GtkBinding to use g_signal_emitv() rather than
> gtk_signal_emitv(). Could you check it over? There are two semi-significant behavior
> changes here:
> 
>  A) Negative values passed to UINT typed signal parameters are now cast
>     rather than producing an error. (Note that no errors were produced
>     for things like longs cast to chars; we just checked this one special
>     case of out-of-range values.) 

yep, though for some types we can do better now. reasonable checks that we
should support there are:
- bool: the incoming long should be 1 or 0
- enums: the incoming long should be found in the enum class
- flags: the incoming long should be constructable out of the flags value

>  B) Strings can no longer be used for a single value out of a flags type.

s/Strings/Identifiers/. i'd rather see the code be adapted to support flags
regularly, than to disable the support for even a single flag value.

> Neither of these would be hard to fix with a bit of extra code, but
> neither strike me as really right, so I'm a little hestitant to add
> that code.

the point in the checks is, it's common even for programmers to screw
up with signal parameters eventhough they have docu available and
usually test code they write.
but for users who adapt their key bindings in rc-files, the situation
is even worse, i doubt a significant portion of them even thinks of
going through the hassle to read the documentation for the signals
they're using in bindings, so we should provide feedback on
misconfiguration wherever possible.

> 
> Regards,
>                                         Owen
> 

---
ciaoTJ