Re: Range patchlet

[Bill Haneman <bill haneman sun com>]

Owen Taylor wrote:

> I can't reproduce this. (With a scale, or if I explicitely make
> a scrollbar focusable.)
> 
> > >  - This patch _is not_ in...
> >
> > I checked it in on Tim's OK awhile ago.
> 
> Into what repository? :-)
...

Hmm, looks as though my checkin failed silently (I have checked my logs
and terminal history, etc.).  

Not good (usually), but maybe fortuitous in this case.

I would like to qualify what I said about the focus line being clipped -
that may be Solaris specific, or perhaps my codebase was old (when I saw
that on Solaris).  What happens now at least on linux is that the focus
line is drawn in the bevel.  This looks basically OK with the default
theme but it looks rather strange using wider focus lines, and also the
slider is then not drawn (apparently) centered on the focus line - that
is, the part of the focus line that is obscured by the slider is
asymmetric (I am sending snapshots to Owen - unfortunately I don't have
a public URL to post them to).

I think it's not a big deal either way, but the patched version looks
slightly better to me.

-Bill


> 
> The last change to gtkrange was a fix from Tim on 9 January.
> 
> Perhaps your commit failed due to a conflict or something?
> 
> Regards,
>                                         Owen