Nautilus Book mark menu bug 78949

[Rajkumar Sivasamy <rajkumar siva wipro com>]

Hi,
The following mail was initially addressed to nautilus-devel and
gnome-devel list, and since it is been realized as gtk specific am
mailing the same here. Have also appended Michael Meeks response for the
same.

Pls pour in your comments.

Thanks,
Raj.
------

Rajkumar Sivasamy wrote:
> 
> Hi,
> Am working on bug 78949 which was logged for "Bookmark menu items being
> vanished when we _add bookmarks_ repeatedly".
> 
> The above issue arises only when we add a bookmark and popup the
> bookmark list menu in quick succession.
> 
> In my analysis I inferred the following:
> a) When a bookmark is added, the existing menu item entries are removed
> from the bookmark menu and then the new menu item entries (both static
> and dynamic) are added to this menu.
> 
> refer: refresh_bookmarks_menu() in nautilus-windows-menus.c. This
> routine takes quite sometime to execute.
> 
> b) And if we popup the bookmark menu before this
> (refresh_bookmarks_menu) routine completes its execution, the menu will
> be truncated with first two menu items (Add and Edit bookmarks). Where
> as if we are poping up this menu after the execution of this routine,
> the entire menu items including the recently added bookmark will be
> displayed.
> 
> Presuming that this behavior is due to gtk_widget_size_request() in
> gtk_menu_popup() returning wrong values for the menu
> allocation[width/height] I hard coded the expected values for the width
> and height, but it doesn't help though.
> 
> I have the following queries here:
> i) Is the above problem a result of queue_resize() of a widget being
> timed out due to the long execution time of refresh_bookmarks_menu() as
> stated in case-b above (or)
> ii) Is it some other gtk issue which is common for any dynamic menus?
> 
> 
> Thanks,
> Raj.


Michael Meeks wrote:
> 
> On Wed, 2002-07-03 at 15:28, Rajkumar Sivasamy wrote:
> > Presuming that this behavior is due to gtk_widget_size_request() in
> > gtk_menu_popup() returning wrong values for the menu
> > allocation[width/height] I hard coded the expected values for the width
> > and height, but it doesn't help though.
> 
>         I imagine it's that the popup window itself is not resized correctly.
> The best place to ask about this is gtk-devel-list gnome org since it's
> clearly a gtk+ bug.
> 
>         I'd use my patch to gtk-demo to test it too, since it neatly isolates
> the problem as in Gtk+ and it's quick to build.
> 
> > I have the following queries here:
> > i) Is the above problem a result of queue_resize() of a widget being
> > timed out due to the long execution time of refresh_bookmarks_menu() as
> > stated in case-b above (or)
> 
>         Nope - it's a gtk+ bug. Simply that if you add items to an already
> popped up menu, it doesn't resize correctly. In some cases you can see
> there are new buttons at the bottom that can receive partial focus, but
> the window is not correctly re-sized.
> 
>         Also you'll notice some cruft in the popup code to do with sizing,
> AFAIR a boolean set that does nothing / isn't read etc.
> 
>         HTH,
> 
>                 Michael.
> 
> --
>  mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot

**************************Disclaimer************************************

Information contained in this E-MAIL being proprietary to Wipro Limited is 
'privileged' and 'confidential' and intended for use only by the individual
 or entity to which it is addressed. You are notified that any use, copying 
or dissemination of the information contained in the E-MAIL in any manner 
whatsoever is strictly prohibited.

***************************************************************************