[Fwd: ORBit2 HEAD broken on Linux] - gthread problem

[Michael Meeks <michael ximian com>]

Hi Guys,

	Is this a feature ?

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot

--- Begin Message ---

• From: Laszlo PETER <Laszlo Peter ireland sun com>
• To: Michael Meeks <michael ximian com>
• Subject: ORBit2 HEAD broken on Linux
• Date: Sun, 07 Jul 2002 12:45:36 +0100

Hi Michael,

There was a change in gthread whereby the -lpthread flag was
replaced with -pthread on Linux.  This caused 2 problems with
ORBit2: 

  - pkg-config has a bug (85244) where it only merges the
    -l... and -L... flags from the requirement libs
    so the -pthread flag will be missing.
    This can be worked around by explicitely listing gthread-2.0
    in PKG_CHECK_MODULES.

  - libtool won't pick up -pthread from the .la files either, so
    I had to add $(ORBIT_LIBS) to the LDADD of the test programs.

Below is the patch I use in my builds.

Laca


Index: configure.in
===================================================================
RCS file: /cvs/GNOME-RE/ORBit2/configure.in,v
retrieving revision 1.87
diff -u -r1.87 configure.in
--- configure.in	2002/06/19 21:23:21	1.87
+++ configure.in	2002/07/07 11:25:38
@@ -110,6 +110,7 @@
 dnl Checks for libraries.
 PKG_CHECK_MODULES(ORBIT, \
 	linc >= $LINC_REQUIRED \
+	gthread-2.0 \
 	glib-2.0 >= $GLIB_REQUIRED \
 	gobject-2.0 >= $GLIB_REQUIRED \
 	gmodule-2.0 >= $GLIB_REQUIRED)
@@ -127,6 +128,7 @@
 PKG_CHECK_MODULES(ORBIT_NAME, \
 	libIDL-2.0 >= $LIBIDL_REQUIRED \
 	linc >= $LINC_REQUIRED \
+	gthread-2.0 \
 	glib-2.0 >= $GLIB_REQUIRED)
 AC_SUBST(ORBIT_NAME_LIBS)
 AC_SUBST(ORBIT_NAME_CFLAGS)
Index: test/Makefile.am
===================================================================
RCS file: /cvs/GNOME-RE/ORBit2/test/Makefile.am,v
retrieving revision 1.25
diff -u -r1.25 Makefile.am
--- test/Makefile.am	2002/06/21 14:54:39	1.25
+++ test/Makefile.am	2002/07/07 11:25:39
@@ -18,7 +18,7 @@
 
 TESTS = test-dynany test-mem test-performance test-giop
 
-LDADD = $(top_builddir)/src/orb/libORBit-2.la
+LDADD = $(top_builddir)/src/orb/libORBit-2.la $(ORBIT_LIBS)
 
 test_mem_SOURCES=test-mem.c
 
Index: test/inhibit/Makefile.am
===================================================================
RCS file: /cvs/GNOME-RE/ORBit2/test/inhibit/Makefile.am,v
retrieving revision 1.7
diff -u -r1.7 Makefile.am
--- test/inhibit/Makefile.am	2001/11/18 19:01:52	1.7
+++ test/inhibit/Makefile.am	2002/07/07 11:25:39
@@ -7,7 +7,7 @@
 	$(WARN_CFLAGS)               \
 	$(ORBIT_CFLAGS)
 
-LDADD = $(top_builddir)/src/orb/libORBit-2.la
+LDADD = $(top_builddir)/src/orb/libORBit-2.la $(ORBIT_LIBS)
 
 FOO_IDLOUT=foo.h foo-stubs.c foo-skels.c foo-common.c
 BAA_IDLOUT=baa.h baa-stubs.c baa-skels.c baa-common.c
Index: test/poa/Makefile.am
===================================================================
RCS file: /cvs/GNOME-RE/ORBit2/test/poa/Makefile.am,v
retrieving revision 1.10
diff -u -r1.10 Makefile.am
--- test/poa/Makefile.am	2001/11/18 19:01:52	1.10
+++ test/poa/Makefile.am	2002/07/07 11:25:39
@@ -30,7 +30,7 @@
 
 check_PROGRAMS = $(TESTS)
 
-LDADD = $(top_builddir)/src/orb/libORBit-2.la
+LDADD = $(top_builddir)/src/orb/libORBit-2.la $(ORBIT_LIBS)
 
 POATEST_IDLOUT = poatest.h poatest-common.c poatest-skels.c poatest-stubs.c

--- End Message ---