Re: My take icon icon resizing

[Tim Janik <timj gtk org>]

On Tue, 1 Oct 2002, Owen Taylor wrote:

> (Tim: if you want to check it over, that could be useful - it's mostly
> changing your code.)

+void
+_gtk_settings_set_property_value_from_rc (GtkSettings            *settings,
+                                         const gchar            *prop_name,
+                                         const GtkSettingsValue *new_value)
+{
[...]

+void
+reset_rc_values_foreach (GQuark    key_id,
+                        gpointer  data,
+                        gpointer  user_data)
this function should be static.


+void
+_gtk_settings_reset_rc_values (GtkSettings *settings)
[...]
+  for (p = pspecs; *p; p++)
+    {
+      GParamSpec *pspec = *p;
+
+      g_value_unset (&settings->property_values[i].value);
+
+      g_value_init (&settings->property_values[i].value, G_PARAM_SPEC_VALUE_TYPE (pspec));
+      g_param_value_set_default (pspec, &settings->property_values[i].value);
i don't see the point in unsetting and newly initializing the value, couldn't
you simply just set_default() ?


 /* implementation details */
+void gtk_settings_set_property_value_from_rc (GtkSettings            *settings,
+                                             const gchar            *name,
+                                             const GtkSettingsValue *svalue);
the function prototype needs an underscore prefix as quoted above.

> 
> Regards,
>                                         Owen
> 
> 

---
ciaoTJ