Re: Question about ingregation of EggMenu code into GTK+



> I made the changes of EggMenu to integrate it into GTK+, but
> I have a couple of doubts as follow:
> 
> There are parts in EggMenu (action, markup, menumerge and
> toggleaction) that depends on EggToolbar.  Well, I made 
> the changes on EggToolbar to integrate them, but EggToolbar
> depends on EggUtils (only EggMarchalers)... So I changed, too.

Note that markup should not be merged; it has been superseded by  
menumerge (see
http://mail.gnome.org/archives/gtk-devel-list/2003-July/msg00189.html)
James also pointed out that the accel dialog probably shouldn't be merged
(http://mail.gnome.org/archives/gtk-devel-list/2003-July/msg00200.html)

> All works fine, but to integrate EggMenu into GTK+ we need
> (I guess) to integrate EggToolbar first, or, remove the
> dependencies from EggMenu.

EggToolbar has already been integrated into HEAD. 

> The example is very useful if includes the EggToolbar, 
> because they are very related.

Yes, the example should probably go to  tests/ as is, and a simplified
version can later be included in gtk-demo.

> OTOH, what would it happed with name space if EggMenu is
> translated to GtkMenu? does it matter?

I don't think it will create any conflicts, will it ? We should get new
classes GtkAction, GtkActionGroup and GtkMenuMerge, with methods 
gtk_action_*, gtk_action_group_* and gtk_menu_merge_*.

Matthias

-- 
COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test
--------------------------------------------------
1. GMX TopMail - Platz 1 und Testsieger!
2. GMX ProMail - Platz 2 und Preis-Qualitätssieger!
3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]