Re: Patch to add g_child_watch_source

[Alexander Larsson <alexl redhat com>]

On Fri, 2003-07-04 at 07:33, Jonathan Blandford wrote:
> Here's a patch partially implementing a fix for bug #50296 (UNIX signal
> main loop source.)  It adds a GSource that notifies the user that a
> particular pid exited.  It allows libraries (such as libvte) to monitor
> children's exit status without having a custom solution or fighting over
> who installs the signal handlers.
> 
> Comments are appreciated,

It doesn't seem needed, but i would sleep better if child_watch_count
was volatile. Also, maybe you should set a smaller than default
stacksize on the helper thread (linux defaults to 128k, which is a bit
much). I can't really comment on deep signal-related issues though, you
should get some old unix-guy to look at it.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a witless white trash romance novelist with acid for blood. She's an 
elegant hypochondriac bounty hunter from Mars. They fight crime!