Re: Patch to add g_child_watch_source
- From: Jonathan Blandford <jrb redhat com>
- To: Alexander Larsson <alexl redhat com>
- Cc: gtk-devel-list gnome org
- Subject: Re: Patch to add g_child_watch_source
- Date: 09 Jul 2003 14:33:29 -0400
Alexander Larsson <alexl redhat com> writes:
> On Fri, 2003-07-04 at 07:33, Jonathan Blandford wrote:
> > Here's a patch partially implementing a fix for bug #50296 (UNIX signal
> > main loop source.) It adds a GSource that notifies the user that a
> > particular pid exited. It allows libraries (such as libvte) to monitor
> > children's exit status without having a custom solution or fighting over
> > who installs the signal handlers.
> >
> > Comments are appreciated,
>
> It doesn't seem needed, but i would sleep better if child_watch_count
> was volatile. Also, maybe you should set a smaller than default
> stacksize on the helper thread (linux defaults to 128k, which is a bit
> much). I can't really comment on deep signal-related issues though, you
> should get some old unix-guy to look at it.
Thanks. These seem to be fine suggestions, and I'll go ahead and make
them. Does anyone think there's a chance this can make it into
glib-2.4? If not, I'll just put it in bugzilla.
-Jonathan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]