Re: visibility problems

[Owen Taylor <otaylor redhat com>]

On Mon, 2003-09-22 at 09:01, Michael Meeks wrote:
> On Fri, 2003-09-19 at 22:17, Owen Taylor wrote:
> > >  gtk_widget_show_all (window);
> > > 
> > > doesn't quite work as intended: It makes all the invisible menu items
> > > visible. 
> ...
> > I don't like leaving this trap. Reusing the compound-child mechanism
> > seems a little peculiar to me. Might it be best to simply add new
> > API:
> >  
> >  gtk_menu_item_set_no_show_all()
> 
> 	Presumably not showing all would be the default; ultimately it has to
> be the uncommon case that you merge a load of menus and don't want them
> to be visible-surely; can they not be made visible by default as they
> are merged ?

We certainly can't change the default for menu items - people do count
on gtk_widget_show_all (menu) working. 

I think the idea is that the merge code would set this flag and then
manage the visibility itself.

I suppose we could make the flag

 gtk_widget_set_show_all_propagates_to_children()

rather than

 gtk_widget_set_show_all_on_parent_affects_widget()

(I'm not suggesting either name, just shooting for clarity.) I really
don't have a big preference.

> 	In BonoboWindow we override show_all and don't do anything with the
> toolbars/menus for precisely this reason.
> 
> 	We (used to) do a similar thing on plug/socket - after all who wants
> the private internal hidden/shown state of their sub-component thrown
> away by a careless parent.

Filing a bug about this in bugzilla would be much appreciated ..
show_all() certainly shouldn't propagate across the plug/socket
boundary.

Regards,
						Owen