Re: PATCH for tab-scrolling

Owen Taylor <otaylor redhat com> writes:

> I don't think there is much point in filing a bug unless you also
> include the appropriate patch.

I've created the patch, and put it here:

It's 176Kb in size, so I didn't dare try to mail it (hrm, I guess I did
mess a little too much with the horizontal aligning).

As for testing, the code still compiles, and random test applications in
tests/ seem to run okay.  I guess there's no automatic test suite?

> A couple of hints about such a patch:
>  A) It shouldn't mix in any other changes but should stick to the
>     one problem of gint vs. gboolean

Apart from minor formatting fixes I couldn't help myself from including
because I was messing with nearby code anyway, check.

>  B) In general, the rough rule of thumb is that groups of related
>     prototypes should be aligned together. So, if gint=>gboolean
>     breaks alignment, you don't need to realign *all* prototypes
>     in the C file, but can simply add a space before and after
>     the event handlers and align those.

Check.  I tried to use my best judgement.

>  C) is quite helpful in
>     producing the correct alignment.

Wow, that's gotta be the best thing since automatic indention.  Thanks,
I already can't live without it.  :-)

Anyway, I'm going to get some sleep, but will file this in bugzilla
later unless someone commits or complains.


Daniel Brockman
drlion deepwood net

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]