Re: GIcon thoughts



On Tue, 2008-01-15 at 21:59 -0500, Matthias Clasen wrote:
> I have committed the stream i/o api in gdk-pixbuf now, after adding
> GCancellable arguments
> and removing the closing of the streams, since that seemed pretty
> uncontroversial.
> 
> Here are new versions of the resurrect-pixbuf and iconinfo patches.  I
> have added a iconinfo-from-pixbuf function. Caching is still not
> implemented, I'd like to do that separately.
> 
> Does the iconinfo patch look ready to commit ?

Yeah that looks ok to me.

For the ressurect part. Looking at gtk_object_dispose() it seems to
protect against reinvocing by using a in_destruction flag. I'm not sure
exactly why, but maybe we need to do that too?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]