Re: [Patch] Cursor cache

["Dr. David Alan Gilbert" <gilbertd treblig org>]

* Matthias Clasen (matthias clasen gmail com) wrote:
> Thanks for the patch. It looks good in general, just a couple of notes:
> 
> * There are some stylistic issues (mostly missing spaces here and there)

No problem; please point out a few of the ones that need fixing and
I'll try and make they all get done.

> * We need to purge cursors from the cache when their display is closed

OK - is there a hook for that? Also is there an easy way to test
multidisplay code like that - what can I easily get to open something
on two displays?

> * Do you have any data how big the cache grows in cursor-heavy apps ?

No, but I've not found anything that uses more than 3 or 4 cursors;
they just open the same damn ones over and over again.  The overhead
for each cache entry is small, cursors seem to vary on disc, but seem
to be between 15 and 35k except for some big ones but you are only paying
a penalty for those that are used rarely.

> Wrt. to dnd cursors, I don't see the problem you mention here. Are you
> sure the themes you change between have different dnd cursors ?

Ah OK that could be the problem; I'd been customizing the theme to redglass
from the defualt DMZ-White but it looks like redglass doesn't have
any of the dnd-*

> Wrt. to blank cursors, adding a new cursor type or special-casing a
> cursor name like "none" would work, although we probably cannot change
> GDK_LAST_CURSOR, judging from google code search results.

It's a pity if GDK_LAST_CURSOR has to stay put, so it probably doesn't
make sense to add a new type. Special caseing the name sounds a bit
odd; since in either case it's effectively changing the API would it
be cleaner just to have a new function call for it?
The other way I'd considered was special casing the pixmap code for 1x1 -
but again that feels dirty.

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    | Running GNU/Linux on Alpha,68K| Happy  \ 
\ gro.gilbert @ treblig.org | MIPS,x86,ARM,SPARC,PPC & HPPA | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/