Re: 3.0-related deprecations
- From: Stefan Kost <ensonic hora-obscura de>
- To: Cody Russell <bratsche gnome org>
- Cc: gtk-devel-list <gtk-devel-list gnome org>
- Subject: Re: 3.0-related deprecations
- Date: Sun, 17 May 2009 20:31:42 +0300
Cody Russell schrieb:
> Hi all,
>
> gtk+ currently does not build with GSEAL enabled, and I want to remedy
> this so we can make progress on 3.0. I'm planning to post a large
> series of patches unless someone has a suggestion for how better to do
> proceed with this.
>
> Right now I was thinking to break this up by widget in order to make it
> somewhat manageable in terms of review. Does this seem like a good
> idea, or should I just do all the work in one enormous branch and post
> for review?
>
> I've posted the first patch[1] and it's about 105k, although it
> shouldn't really be a big burden to review.. it adds 5 new API functions
> for public struct members that didn't previously have API, otherwise
> there's not much of interest in it. I used the code rewriter to
> generate parts of it, but had to insert all the "GtkPrivate *priv =
> GTK_WINDOW_GET_PRIVATE (window)" type stuff somewhat manually.
it not doing this for every call? just want to check that you set up the priv
pointer as a private field in the object struct and dereference from there.
stefan
>
> Last thing is what to do with this stuff. Assuming someone is able and
> willing to review it, should it go in git HEAD or should we make another
> branch for it? My preference is to just put it in git HEAD probably.
>
> Thanks,
> Cody
>
> [1]. http://bugzilla.gnome.org/show_bug.cgi?id=582018
>
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]