Re: filesystemmodel branch - initial testing

[Federico Mena Quintero <federico ximian com>]

On Thu, 2009-10-01 at 01:48 +0100, Bastien Nocera wrote:

> Not having looked at the code since the original patches, have all the
> concerns about the possible regressions and incremental changes been
> addressed?

I did a *very* careful review of the code, and it seems sane.  If you
look at the "filesystemmodel" branch, you'll see essentially these
commits:

 - one-shot rewrite of GtkFileSystemModel
 - Company's extra fixes, adapting GtkFileChooserDefault to use it
 - Cleanup of GtkFileChooserDefault to make recent/search use the model
 - Federico's nitpicks, cleanups, a few bug fixes
 - A big in-source comment explaining how the new model works

Basically, I'm happy that we have a) at least two people who know how
the model works; b) documentation on it, for posterity.  We had neither
of those with the old GtkFileSystemModel :)

I hope there will be no be regressions with the file chooser's behavior;
the code doesn't touch that.  It's all concerned with how the file list
is shown.

Of course, help with testing is much appreciated.  I'll merge master to
the filesystemmodel branch to get in the unrelated fixes in master, and
then you can test that easily.

  Federico